From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: package.el dependencies Date: Mon, 02 Feb 2015 22:19:05 +0100 Message-ID: <87bnlc3tbq.fsf@gmail.com> References: <87wq4dpqib.fsf@gmail.com> <87wq44su8v.fsf@gmail.com> <878ugj7ajz.fsf@gmail.com> <874mr67gjb.fsf@gmail.com> <87oapervqv.fsf@gmail.com> <877fw2kp1y.fsf@gmail.com> <87d25tps2q.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422911976 32603 80.91.229.3 (2 Feb 2015 21:19:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2015 21:19:36 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 22:19:35 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIOP6-00069w-7D for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 22:19:32 +0100 Original-Received: from localhost ([::1]:56755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIOP5-00028s-Ca for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 16:19:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIOOr-00028l-FG for emacs-devel@gnu.org; Mon, 02 Feb 2015 16:19:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIOOn-0004fa-D2 for emacs-devel@gnu.org; Mon, 02 Feb 2015 16:19:17 -0500 Original-Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:50550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIOOn-0004fR-6k for emacs-devel@gnu.org; Mon, 02 Feb 2015 16:19:13 -0500 Original-Received: by mail-wg0-f43.google.com with SMTP id y19so41186586wgg.2 for ; Mon, 02 Feb 2015 13:19:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=XBAZYGGQc9VXvmipl5CaAiSQSn+IXDo2xsX9lPZSFgs=; b=PiHvqcZhAUJJTHIbk34W49hDbfzHRdaXGswVsmjZOdGI54P7Gs3aNZMqy1x3gkKULV b6+aOCdAhxm+iKfKu1f/GlRCEghWsa2mUivlsUE5n6cW/ATyktnk4y2rasqEjE9sdb8t jH7tN3llHfAvM3+BG3Wp2Ks/HX0P5Jf0fg/ppfG1htmXkkwzttVyxVeJIZjFpQ0Qk9QS 6yMG+wvKvGR+2lA+eScmDTTpFFbhwwip/K19Nw8yoQeqP7dH+pNV0mtmd2nXLCsFMtAS aieaRpg1DDitbwINJ852k6Pt3zRqr9S/f/C5EOLmlZAvx+tLgXBTC1q99zRiATH6EKzv pAnA== X-Received: by 10.180.80.163 with SMTP id s3mr27597136wix.59.1422911952643; Mon, 02 Feb 2015 13:19:12 -0800 (PST) Original-Received: from dell-14z ([37.163.229.5]) by mx.google.com with ESMTPSA id e4sm29580218wjw.48.2015.02.02.13.19.10 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Feb 2015 13:19:11 -0800 (PST) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182292 Archived-At: Stefan Monnier writes: > Looks good, feel free to install. See some further comments below. The version of package--get-deps Arthur pushed (he modify original version) returns many duplicates and I am not sure it recurse correctly, I suggest this version (See discussion on emacs-devel), can you review it ? Thanks. --8<---------------cut here---------------start------------->8--- (defun package--get-deps (pkg &optional only) (let* ((pkg-desc (cadr (assq pkg package-alist))) (direct-deps (cl-loop for p in (package-desc-reqs pkg-desc) for name = (car p) when (assq name package-alist) collect name)) (indirect-deps (unless (eq only 'direct) (cl-loop for p in direct-deps append (package--get-deps p 'direct) into lst finally return (delete-dups lst))))) (cl-case only (direct direct-deps) (separate (list direct-deps indirect-deps)) (indirect indirect-deps) (t (append direct-deps indirect-deps))))) --8<---------------cut here---------------end--------------->8--- -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997