From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix-info-dups 6316172: Fix duplicates when completing Info files Date: Mon, 20 Apr 2015 17:16:10 +0200 Message-ID: <87bniiesp1.fsf@gmail.com> References: <20150420122827.13008.83006@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429543332 21645 80.91.229.3 (20 Apr 2015 15:22:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Apr 2015 15:22:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 20 17:22:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YkDWV-0000iU-HD for ged-emacs-devel@m.gmane.org; Mon, 20 Apr 2015 17:22:11 +0200 Original-Received: from localhost ([::1]:54141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkDWP-00056n-So for ged-emacs-devel@m.gmane.org; Mon, 20 Apr 2015 11:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkDWA-000562-Tt for emacs-devel@gnu.org; Mon, 20 Apr 2015 11:21:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkDW6-0000Qe-Sb for emacs-devel@gnu.org; Mon, 20 Apr 2015 11:21:50 -0400 Original-Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkDW6-0000QR-L5 for emacs-devel@gnu.org; Mon, 20 Apr 2015 11:21:46 -0400 Original-Received: by wiun10 with SMTP id n10so95924097wiu.1 for ; Mon, 20 Apr 2015 08:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=N1r+1e5EVeCRGic+JhK+6L8t4xjmrRzrvlaimFooh3k=; b=EciC/X0H8jxWsk1Aj87LS74y4bhqRN42zKyJl9hDoxm81+9EKqygXAGMs0KgTWIqzM Em6jasd7SnG7RV6+AQJuBK0uPkrz7uVbk5RO8XS1BnDL74aFmCqFR/QVfmmIb+GwOu7o M7sJnVVDiuJ4SKJfqfnzqhSO+vkFXk0+gdKMIebMDZUX92F/SFtQgAXo1OL9FLtD8oEP 2gbNb+/ExWLJFgtgEXCBCoXVxZQvb5p5OMIBIsaMreh4I8Acbd6zDs/nXWiEN9DlZwm1 uLKD8QQGQ0wLsEuue9zSIysdzeVWsAtIjGthh6BGqcyFsTl4Y05LLtLLyRQyKnPuXkKt zcwg== X-Received: by 10.181.13.144 with SMTP id ey16mr26524507wid.38.1429543305873; Mon, 20 Apr 2015 08:21:45 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id dj5sm27702865wjb.28.2015.04.20.08.21.45 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 20 Apr 2015 08:21:45 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 20 Apr 2015 10:58:36 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185712 Archived-At: Stefan Monnier writes: >> * lisp/info.el (Info-read-node-name-2): Use the STRING argument a lot >> less, it's actually always "". > > What makes you think it's always ""? I deduced it from the two calls to it and the setup of my system. I may be wrong. > I haven't actually tested your patch, but the way I read it, I get the > impression that it will break things like > > C-h i g (emacs-23/e TAB > and > C-h i g (/usr/sh TAB OK, my impression was that only the files on `Info-directory-list' were acceptable. So actually it should be possible to navigate to any info file on the filesystem? >> Update the regex to remove the split files, the old one wasn't >> working properly. > > But the new one only handles those cases where the ".info" extension is > present, which is sadly not always the case (yup, the conventions about how > to name info files suck). OK, I'll work on it some more. > But I also wonder whether we couldn't try to reduce the amount of > duplication (at least in some of the common cases) even before passing > the result through delete-dups. > IOW, I'm wondering where the duplication actually comes from. In my case, it comes from `Info-directory-list': ("/usr/local/info/" "/usr/share/info/" "/usr/local/share/info/") I didn't mess with it on my own, this is the default value. These dirs have some intersections, hence the duplicates. So they're not actually duplicates, but duplicate info files, but there's no way to know which one is which from the completion system. Oleh