From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#21058: 25.0.50; delete-dups doesn't delete all duplicates Date: Wed, 15 Jul 2015 08:40:06 +0300 Message-ID: <87bnfef07d.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1436938879 17930 80.91.229.3 (15 Jul 2015 05:41:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jul 2015 05:41:19 +0000 (UTC) To: 21058@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 15 07:41:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZFFRM-0003y0-RN for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jul 2015 07:41:09 +0200 Original-Received: from localhost ([::1]:33868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFRM-00072E-4T for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jul 2015 01:41:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFRI-000727-S2 for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFFRG-0004ef-EP for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:41:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFRG-0004eb-At for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZFFRF-0003lz-VS for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jul 2015 05:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21058 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.143693882314446 (code B ref -1); Wed, 15 Jul 2015 05:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jul 2015 05:40:23 +0000 Original-Received: from localhost ([127.0.0.1]:49509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFFQc-0003kv-MA for submit@debbugs.gnu.org; Wed, 15 Jul 2015 01:40:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49146) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFFQb-0003kh-0Y for submit@debbugs.gnu.org; Wed, 15 Jul 2015 01:40:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFFQU-0004VR-Ob for submit@debbugs.gnu.org; Wed, 15 Jul 2015 01:40:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFQU-0004VJ-Kq for submit@debbugs.gnu.org; Wed, 15 Jul 2015 01:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFQT-000706-MB for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:40:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFFQR-0004Ug-37 for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:40:13 -0400 Original-Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:36791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFFQQ-0004UN-S5 for bug-gnu-emacs@gnu.org; Wed, 15 Jul 2015 01:40:11 -0400 Original-Received: by widjy10 with SMTP id jy10so117830163wid.1 for ; Tue, 14 Jul 2015 22:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=QCSXDxnrVRbysiVyDX5XM2fdCd8vj56vxzdKwdikASw=; b=pKyyPSVUQ4jNHsWZVUwui23mEbrV5EjUxYjFdWtG4/Frx+JV5eECR5/SoBi01TfTmI gGsnoyd+nY/wTJhVw6szf0tpYYC067lDsSXg2UvxYmPpPUa1ZcY5q0WUNgt4txl6j0xa OSgogHO166hdtRxAiszKASP8cl52lY3V73t8jX6hflfFZy9jxIIv+lO24Dc+bo7fK7Id 9OpvEPjyuaAIJ2RQ+yG2opq61OOgX4gyzTS5r5URjPvmGXIfyHixzvYF7lU7OJuNSX02 +sjWJ5SFUkCnbOhRhAw0Mqi7ftsgwwUp4Y/lccMgorgML+RXp0gG+ayXLzHgPJT/Tf16 eKww== X-Received: by 10.180.20.48 with SMTP id k16mr40509633wie.56.1436938809321; Tue, 14 Jul 2015 22:40:09 -0700 (PDT) Original-Received: from arirop ([2001:2003:f38b:ea00:51b:8c18:4899:63a6]) by smtp.gmail.com with ESMTPSA id x5sm7174234wif.21.2015.07.14.22.40.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2015 22:40:08 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104974 Archived-At: Tags: patch Function delete-dups doesn't delete all duplicates from long lists: (delete-dups (mapcar (lambda (x) (% x 3)) (number-sequence 0 102))) => (0 1 2 1 0 2 1 0 2 1 0 2 ...) The following patch seems to fix the problem. * lisp/subr.el (delete-dups): Fix paren typo. diff --git a/lisp/subr.el b/lisp/subr.el index 5bd4bb4..e2c1bae 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -426,8 +426,8 @@ one is kept." (let ((elt (car retail))) (if (gethash elt hash) (setcdr tail (cdr retail)) - (puthash elt t hash))) - (setq tail retail))) + (puthash elt t hash) + (setq tail retail))))) (let ((tail list)) (while tail (setcdr tail (delete (car tail) (cdr tail))) In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.17.4) of 2015-07-14 on arirop Repository revision: 6a7e718916d00dbacaa765669f389b86f33075f5 Windowing system distributor `Fedora Project', version 11.0.11702000 System Description: Fedora release 23 (Rawhide) -- Ari Roponen