From: Oleh Krehel <ohwoeowho@gmail.com>
To: org mode <emacs-orgmode@gnu.org>
Subject: Is it possible to remove org-completing-read and org-completing-read-no-i?
Date: Tue, 28 Jul 2015 17:23:31 +0200 [thread overview]
Message-ID: <87bnew487g.fsf@gmail.com> (raw)
Hi all,
I'd like to remove them in favor of using `org-icompleting-read'
everywhere (or better yet, `completing-read').
`org-completing-read-no-i' doesn't do much, is called twice and can be
replaced with a let binding wrapper.
`org-completing-read' could be updated this way:
(defmacro with-org-minibuffer-keys (&rest body)
"Minibuffer read with SPACE being a normal character."
`(let ((enable-recursive-minibuffers t)
(minibuffer-local-completion-map
(copy-keymap minibuffer-local-completion-map)))
(org-defkey minibuffer-local-completion-map " " 'self-insert-command)
(org-defkey minibuffer-local-completion-map "?" 'self-insert-command)
(org-defkey minibuffer-local-completion-map (kbd "C-c !") 'org-time-stamp-inactive)
,@body))
(with-org-minibuffer-keys
(org-icompleting-read args))
This change will simplify the code nicely. One example that bothers me
is `org-tags-completion-function': it's essentially a hacky closure that
relies on several dynamic variables being set:
`org-last-tags-completion-table' and
`org-add-colon-after-tag-completion' are implicit arguments to this
function.
With the proposed change, each use of `org-tags-completion-function'
will be in conjunction with `org-icompleting-read'. That means a new
function can be written:
(defun org-read-tags (tag-list &optional colon)
(let ((org-last-tags-completion-table tag-list)
(org-add-colon-after-tag-completion colon))
(org-icompleting-read
"Tag: " 'org-tags-completion-function
;; ...
)))
I think it's a better interface, since the coupling is now made
explicit, instead of having to remember to set
`org-last-tags-completion-table' and
`org-add-colon-after-tag-completion' each time
`org-tags-completion-function' is to be used.
An even better thing to do would be to use "lexical-binding: t", remove
`org-tags-completion-function' and have it be a real closure inside
`org-read-tags'. Is there any wish or effort to move Org to
lexical-binding? Adding it would allow us to get rid of those dynamic
variables and `org-tags-completion-function' altogether and have the
lambda enclose on tag-list and colon instead.
regards,
Oleh
next reply other threads:[~2015-07-28 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 15:23 Oleh Krehel [this message]
2015-07-28 15:59 ` Is it possible to remove org-completing-read and org-completing-read-no-i? Rasmus
2015-08-05 0:01 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnew487g.fsf@gmail.com \
--to=ohwoeowho@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.