From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 188f657: Fix false negatives in tex--prettify-symbols-compose-p. Date: Wed, 30 Sep 2015 12:45:50 +0200 Message-ID: <87bnckmbhd.fsf@gnu.org> References: <20150925210512.18505.12538@vcs.savannah.gnu.org> <8737xxjtkq.fsf@gnu.org> <87wpv8mgeh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443681249 1627 80.91.229.3 (1 Oct 2015 06:34:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 06:34:09 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 01 08:34:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhXRF-0002nz-9c for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 08:33:57 +0200 Original-Received: from localhost ([::1]:38588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhXRE-0005Dp-GE for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 02:33:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhEtZ-0002oD-LM for emacs-devel@gnu.org; Wed, 30 Sep 2015 06:45:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhEtV-00042C-JU for emacs-devel@gnu.org; Wed, 30 Sep 2015 06:45:57 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:39040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhEtV-000425-Co for emacs-devel@gnu.org; Wed, 30 Sep 2015 06:45:53 -0400 Original-Received: from thinkpad-t440p (dhcp145.uni-koblenz.de [141.26.71.145]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 1202E1A82C5; Wed, 30 Sep 2015 12:45:51 +0200 (CEST) Mail-Followup-To: Artur Malabarba , Davis Herring , emacs-devel In-Reply-To: (Artur Malabarba's message of "Wed, 30 Sep 2015 11:08:52 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 141.26.64.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190513 Archived-At: Artur Malabarba writes: >>>> Could mimicking (better: merging with) the approach of reveal-mode >>>> help? >>> >>> Now that Tassilo seems to have it working, I don't think it's worth >>> mimicking something else. However, if the feature can be simplified >>> by merging with reveal mode then that would surely be nice. >> >> I didn't get Davis email until now > > He accidentally sent it only to me (instead of to the list). Ah, ok. >> (and it seems that mails from or to >> emacs-devel are somehow deferred; do you have such issues, too?) > > I have noticed that when I try to "reply-all" one of your emails your > address is never included in the To: field (I added it manually now). Hm, that probably depends on your mail client. When I follow up to your mails on emacs-devel using Gnus, you'll be in To and emacs-devel in Cc. > The list address does get included, though, so you probably receive > the emails anyway. Yes, the problem is only that mails directed to my email address are delivered immediately while I haven't received mail from emacs-devel for several hours. This includes for example your mail I'm just replying to... >> We can't use that because `reveal-mode' is specialized for revealing >> overlays whereas `prettify-symbols-mode' uses text properties. > > Alright. I tested the code now and it works well. My only suggestion > would be to change this: > (< (point) (car prettify-symbols--current-symbol-bounds)) > to this: > (<= (point) (car prettify-symbols--current-symbol-bounds)) > But I guess that's more of a personal preference. Yes, I think so too. But feel free to add that feature, e.g., by having another possibile value for `prettify-symbols-unprettify-at-point'. > Either way I think it looks good to merge. Done and thanks! Tassilo