From: Tassilo Horn <tsdh@gnu.org>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 188f657: Fix false negatives in tex--prettify-symbols-compose-p.
Date: Wed, 30 Sep 2015 12:45:50 +0200 [thread overview]
Message-ID: <87bnckmbhd.fsf@gnu.org> (raw)
In-Reply-To: <CAAdUY-KMfRzh882j8bb5cyLGUUVnwHWiFxb6NPfbMdgoU4otfQ@mail.gmail.com> (Artur Malabarba's message of "Wed, 30 Sep 2015 11:08:52 +0100")
Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>>> Could mimicking (better: merging with) the approach of reveal-mode
>>>> help?
>>>
>>> Now that Tassilo seems to have it working, I don't think it's worth
>>> mimicking something else. However, if the feature can be simplified
>>> by merging with reveal mode then that would surely be nice.
>>
>> I didn't get Davis email until now
>
> He accidentally sent it only to me (instead of to the list).
Ah, ok.
>> (and it seems that mails from or to
>> emacs-devel are somehow deferred; do you have such issues, too?)
>
> I have noticed that when I try to "reply-all" one of your emails your
> address is never included in the To: field (I added it manually now).
Hm, that probably depends on your mail client. When I follow up to your
mails on emacs-devel using Gnus, you'll be in To and emacs-devel in Cc.
> The list address does get included, though, so you probably receive
> the emails anyway.
Yes, the problem is only that mails directed to my email address are
delivered immediately while I haven't received mail from emacs-devel for
several hours. This includes for example your mail I'm just replying
to...
>> We can't use that because `reveal-mode' is specialized for revealing
>> overlays whereas `prettify-symbols-mode' uses text properties.
>
> Alright. I tested the code now and it works well. My only suggestion
> would be to change this:
> (< (point) (car prettify-symbols--current-symbol-bounds))
> to this:
> (<= (point) (car prettify-symbols--current-symbol-bounds))
> But I guess that's more of a personal preference.
Yes, I think so too. But feel free to add that feature, e.g., by having
another possibile value for `prettify-symbols-unprettify-at-point'.
> Either way I think it looks good to merge.
Done and thanks!
Tassilo
next prev parent reply other threads:[~2015-09-30 10:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150925210512.18505.12538@vcs.savannah.gnu.org>
[not found] ` <E1ZfaB6-0004p6-FL@vcs.savannah.gnu.org>
2015-09-26 4:54 ` [Emacs-diffs] master 188f657: Fix false negatives in tex--prettify-symbols-compose-p Stefan Monnier
2015-09-26 5:36 ` Tassilo Horn
2015-09-26 5:46 ` Tassilo Horn
2015-09-29 11:29 ` Artur Malabarba
2015-09-29 12:31 ` Tassilo Horn
2015-09-29 13:14 ` Artur Malabarba
2015-09-30 6:46 ` Tassilo Horn
2015-09-30 7:48 ` Artur Malabarba
[not found] ` <B393F5AD12955C48A84FFB08032CD04F6C218AED@ECS-EXG-P-MB01.win.lanl.gov>
2015-09-30 7:51 ` Artur Malabarba
2015-09-30 8:59 ` Tassilo Horn
2015-09-30 10:08 ` Artur Malabarba
2015-09-30 10:45 ` Tassilo Horn [this message]
2015-09-30 11:12 ` Artur Malabarba
2015-09-30 11:29 ` Tassilo Horn
2015-10-01 1:17 ` Artur Malabarba
2015-10-01 11:43 ` Tassilo Horn
2015-10-01 1:19 ` Artur Malabarba
2015-10-01 11:45 ` Tassilo Horn
2015-09-29 19:46 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnckmbhd.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.