From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function. Date: Thu, 26 Nov 2015 10:32:53 +0000 Message-ID: <87bnahaw4q.fsf@russet.org.uk> References: <20151120221320.21643.45342@vcs.savannah.gnu.org> <87k2p8aa0n.fsf@russet.org.uk> <87vb8py9wc.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448534003 28956 80.91.229.3 (26 Nov 2015 10:33:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Nov 2015 10:33:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 26 11:33:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1trV-0000fB-AY for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 11:33:13 +0100 Original-Received: from localhost ([::1]:50326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1trS-0000L2-Ar for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 05:33:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1trF-0000Kf-Nt for emacs-devel@gnu.org; Thu, 26 Nov 2015 05:32:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1trC-0000SG-Eb for emacs-devel@gnu.org; Thu, 26 Nov 2015 05:32:57 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:44471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1trC-0000SB-8C for emacs-devel@gnu.org; Thu, 26 Nov 2015 05:32:54 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a1trB-00086s-CH; Thu, 26 Nov 2015 10:32:53 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a1trB-0001PM-No; Thu, 26 Nov 2015 10:32:53 +0000 In-Reply-To: (Stefan Monnier's message of "Wed, 25 Nov 2015 23:00:35 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195278 Archived-At: Stefan Monnier writes: >> Does this seem a reasonable solution (I've used the idea behind your >> patch, but with variables that already exist in keyboard.c)? > > As pointed out in the reply to the actual commit-diff, Sorry, I think I missed that one. > the new code has another problem: it always uses the "point at > beginning of command", which is usually right but not when an > undo-boundary was pushed between "beginning of command" and the moment > when we try to record point. I really should stop thinking for myself and just do what I am told. I've pushed a new version. Phil