From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22466@debbugs.gnu.org
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Date: Wed, 27 Jan 2016 20:20:43 +0000 [thread overview]
Message-ID: <87bn86ojtw.fsf@gmail.com> (raw)
In-Reply-To: <831t9414it.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2016 22:15:22 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> So disable-theme actually means go back to the default theme? If so,
> when someone changes a theme, they don't really need to call
> disable-theme, right? They could just call load-theme with the new
> theme as an argument?
I'm not sure why you reach this conclusion. `disable-theme' is meant to
disable a single theme. If I have theme X enabled, then (disable-theme 'X) is
supposed to restore the default Emacs appearance. If have two themes enabled (X
and Y), then (disable-theme 'X) is supposed to give me just the
appearance of theme Y.
Right now, that's indeed what it does. But if I remove the form (as you
asked) then it fails to do the above (it doesn't remove the background
set by the disabled theme).
> Then it would make sense to find a way of switching a theme without
> changing the frame's background color, if that's possible (i.e. if the
> new theme keeps the same background color). If there's a function
> missing for that, I'd suggest to add one.
How about just running that form only when necessary (i.e., only if the
disabled theme actually sets the frame `background-color')?
next prev parent reply other threads:[~2016-01-27 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 9:02 bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Artur Malabarba
2016-01-26 14:58 ` Eli Zaretskii
2016-01-26 16:36 ` Drew Adams
2016-01-26 17:03 ` Eli Zaretskii
2016-01-26 18:41 ` Michael Albinus
2016-01-26 18:55 ` Eli Zaretskii
2016-01-26 19:31 ` Michael Albinus
[not found] ` <<87y4bc89pt.fsf@gmx.de>
[not found] ` <<834me01881.fsf@gnu.org>
2016-01-26 23:02 ` Drew Adams
2016-01-26 17:25 ` Artur Malabarba
2016-01-26 20:15 ` Eli Zaretskii
2016-01-27 20:20 ` Artur Malabarba [this message]
2016-01-28 3:36 ` Eli Zaretskii
[not found] <<87y4bcsogq.fsf@gmail.com>
[not found] ` <<83powo1j71.fsf@gnu.org>
[not found] ` <<1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
[not found] ` <<83d1so1df3.fsf@gnu.org>
2016-01-26 17:07 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn86ojtw.fsf@gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=22466@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.