From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Fri, 15 Apr 2016 15:11:14 +0200 Message-ID: <87bn5bc8zx.fsf@gmx.de> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460725946 16707 80.91.229.3 (15 Apr 2016 13:12:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2016 13:12:26 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 15 15:12:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ar3Xi-0003x8-SL for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Apr 2016 15:12:15 +0200 Original-Received: from localhost ([::1]:33937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar3Xi-0007TS-7x for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Apr 2016 09:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar3XZ-0007Lb-G7 for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2016 09:12:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar3XW-0004nM-72 for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2016 09:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar3XW-0004nI-2w for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2016 09:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ar3XV-0000jQ-SO; Fri, 15 Apr 2016 09:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, Dmitry Gutov Resent-Date: Fri, 15 Apr 2016 13:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.14607258842767 (code B ref 20637); Fri, 15 Apr 2016 13:12:01 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 13:11:24 +0000 Original-Received: from localhost ([127.0.0.1]:36372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Wu-0000iZ-Ii for submit@debbugs.gnu.org; Fri, 15 Apr 2016 09:11:24 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:55629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Ws-0000iL-EG for 20637@debbugs.gnu.org; Fri, 15 Apr 2016 09:11:23 -0400 Original-Received: from detlef.gmx.de ([87.146.62.238]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MOfx8-1aoKV33i6A-0064lc; Fri, 15 Apr 2016 15:11:16 +0200 In-Reply-To: <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> (Dmitry Gutov's message of "Fri, 15 Apr 2016 03:20:59 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:WgK4RswIrb3VCGSQdgo0dQ0eqaFcfuiNtMN/nnpaNIwPgaDajbA nqqiiKnCrddICXXutzvs1j9ioSzHwbMsTGMD+lemEwP+fYL8tvcxvmOA4ro7Pi/qQialmqP wz5dnxTFqX3l6/vN+ltVyJ8/E1yDZHOdmqrQyrDon9DZh/+C4Zxg4LPa8kFyBtMM3l812Vk fhzTb1dTWa9wbEKX0cqww== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q0L4ts7M/DA=:tI4RZKQAqw4sORV5z+Ek6f dbpdI3XJ99jN8whmnSZpgjv40ZWNp9OixNM4XbaSr1YOpbxn25eyJKoPn03suZJ4f8uS8YbzA i0Fjl4hLQ+vrUG/eO3K/1lxEnnR4CNkcvPSwcJJbT+4sNR8m63U4So71ue80LwqRKB6CS7v3c u5OtWzWOFLcrk3EX+G2Z1oqF8svJq09271fGYmcnF5alI+9h8fGC3AupnS83UKr48uX+rtLsW UoAlLDF9aETN1nTxNRqqoB/mjaLn1Dhj+btCXUpmD1FVFqNaiQks46zWeFeq7a/7g4b8b2JB7 hQvsrcEfjbmM/RBHYIesKZfs/P2G7T0agQYGMxr8ROUdYXLUYeWBfA2MAL6KF02/818+wnXmd BFnC7kSPFtxUpbu9JyJdKQui+X1W/CauVrJHRBsvhuxz5VzG9Fdm/K1RfGvgQ/oNZqbyu8jo/ bwUk0OQn0HLdq0ADkrZpzWIF6S7MY7HBBUV46fpMbcQT7Zq924sVzJuiTZeFFRU0PLfGi0FX3 QIuk4EhDyypD7sVPqAJyFVXIq9qyXOTWC7FSu4veMN1nkojCmeUxeZJPwjovRq3Q3e+EBayrS kxA0ziuydlRQlKtFSligo6yVx+nYH3dEaB8OjuYGrd/l/NUoO4/DrT0xNTsNU//q9nLeyZYsK Gjy254pfkWx7ELOM9A/YSQ2N3eychMTTecx49tx9JfDX5MWwBqKcOROtpgn+Wa9LAyjplouqW nKpVtBTMSLY/+Q1snxLMDCLOazmV0YpBE6UmjbpMLtZkupP/lOuw64xF4SvYvNgqyxT6WkDJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116501 Archived-At: Dmitry Gutov writes: > Thanks. Any objections to committing this follow-up patch? > > It makes the tests look a lot more meaningful, and it passes for all > backends, AFAICT, but I don't have e.g. Monotone installed. I would prefer to apply further patches to the master branch only. Only patches absolutely necessary for fixing problems shall go to the emacs-25 branch, in order not to threaten the release. After applying your patch, vc-tests.el fails for me in vc-test-src02-state and vc-test-rcs03-working-revision. > @@ -205,12 +205,10 @@ vc-test--create-repo > (defun vc-test--unregister-function (backend file) > "Run the `vc-unregister' backend function. > For backends which dont support it, `vc-not-supported' is signalled." > - > - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) > - (if (functionp symbol) > - (funcall symbol file) > - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. > - (signal 'vc-not-supported (list 'unregister backend))))) > + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal > + ;; `vc-not-supported'. > + (vc-call-backend backend 'unregister file) > + (vc-file-clearprops file)) As said, in the master branch I would prefer to add a vc-unregister function. Then we won't need this anymore. Best regards, Michael.