bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Peter Münster]

Hi,

With latest git-emacs, I get this error, after org-timestamp-up-day on a
time-stamp:

org-timestamp-change: Invalid time zone specification: (nil nil nil)

How could I make org-timestamp-up-day work again please?

TIA for any help,
-- 
           Peter

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Eli Zaretskii]

> From: Peter Münster <pmlists@free.fr>
> Date: Sat, 16 Apr 2016 11:08:30 +0200
> 
> With latest git-emacs, I get this error, after org-timestamp-up-day on a
> time-stamp:
> 
> org-timestamp-change: Invalid time zone specification: (nil nil nil)
> 
> How could I make org-timestamp-up-day work again please?

Please show a complete recipe for reproducing this problem, starting
with "emacs -Q".  (I tried something simple and probably stupid, but
couldn't reproduce this.)

Thanks.

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Peter Münster]

On Sat, Apr 16 2016, Eli Zaretskii wrote:

> Please show a complete recipe for reproducing this problem, starting
> with "emacs -Q".

- emacs -Q
- open /tmp/foo.org
- M-x org-mode
- M-S-return (org-insert-todo-heading)
- C-c C-d (org-deadline)
- go to the time-stamp
- M-x org-timestamp-up-day

-- 
           Peter

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Michael Heerdegen]

Peter Münster <pmlists@free.fr> writes:

> - emacs -Q
> - open /tmp/foo.org
> - M-x org-mode
> - M-S-return (org-insert-todo-heading)
> - C-c C-d (org-deadline)
> - go to the time-stamp
> - M-x org-timestamp-up-day

I saw that, too.

And I got a similar error after hitting t d in the agenda (aka "mark as
done").  After the error happened, the according entry in the todo file
was broken...not good.

Michael.

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Eli Zaretskii]

> From: Peter Münster <pmlists@free.fr>
> Cc: 23299@debbugs.gnu.org
> Date: Sat, 16 Apr 2016 13:39:09 +0200
> 
> On Sat, Apr 16 2016, Eli Zaretskii wrote:
> 
> > Please show a complete recipe for reproducing this problem, starting
> > with "emacs -Q".
> 
> - emacs -Q
> - open /tmp/foo.org
> - M-x org-mode
> - M-S-return (org-insert-todo-heading)
> - C-c C-d (org-deadline)
> - go to the time-stamp
> - M-x org-timestamp-up-day

Thanks.  With this recipe, the problem happens on master, but not on
the emacs-25 branch.  This is because encode-time on master no longer
accepts a list of (nil nil nil) as a valid time-zone specification.
That list looks wrong to me, so it sounds like a bug in Org that was
exposed by the recent changes in encode-time.

bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Thanks for reporting the problem. As Eli suggested, it was a typo in org.el that 
was exposed by recent changes to encode-time. I installed into master the 
attached patch, which I think fixes the bug.

[-- Attachment #2: 0001-Fix-org-timestamp-change-typo.txt --]
[-- Type: text/plain, Size: 1201 bytes --]

From 313ebbbb98ceb078468498998305749b2790b7ba Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@penguin.cs.ucla.edu>
Date: Wed, 20 Apr 2016 00:06:01 -0700
Subject: [PATCH] Fix org-timestamp-change typo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem reported by Peter Münster (Bug#23299).
* lisp/org/org.el (org-timestamp-change): Fix typo that relied
on undocumented behavior in ‘encode-time’.  In practice the
old code used local time, so use that.
---
 lisp/org/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org/org.el b/lisp/org/org.el
index 3abf627..b0e1e20 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -17459,8 +17459,7 @@ org-timestamp-change
 			 (+ (if (eq org-ts-what 'hour) n 0)   (nth 2 time0))
 			 (+ (if (eq org-ts-what 'day) n 0)    (nth 3 time0))
 			 (+ (if (eq org-ts-what 'month) n 0)  (nth 4 time0))
-			 (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))
-			 (nthcdr 6 time0)))
+			 (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))))
       (when (and (member org-ts-what '(hour minute))
 		 extra
 		 (string-match "-\\([012][0-9]\\):\\([0-5][0-9]\\)" extra))
-- 
2.5.5