* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
@ 2016-04-16 9:08 Peter Münster
2016-04-16 10:57 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Peter Münster @ 2016-04-16 9:08 UTC (permalink / raw
To: 23299
Hi,
With latest git-emacs, I get this error, after org-timestamp-up-day on a
time-stamp:
org-timestamp-change: Invalid time zone specification: (nil nil nil)
How could I make org-timestamp-up-day work again please?
TIA for any help,
--
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
2016-04-16 9:08 bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil) Peter Münster
@ 2016-04-16 10:57 ` Eli Zaretskii
2016-04-16 11:39 ` Peter Münster
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2016-04-16 10:57 UTC (permalink / raw
To: Peter Münster; +Cc: 23299
> From: Peter Münster <pmlists@free.fr>
> Date: Sat, 16 Apr 2016 11:08:30 +0200
>
> With latest git-emacs, I get this error, after org-timestamp-up-day on a
> time-stamp:
>
> org-timestamp-change: Invalid time zone specification: (nil nil nil)
>
> How could I make org-timestamp-up-day work again please?
Please show a complete recipe for reproducing this problem, starting
with "emacs -Q". (I tried something simple and probably stupid, but
couldn't reproduce this.)
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
2016-04-16 10:57 ` Eli Zaretskii
@ 2016-04-16 11:39 ` Peter Münster
2016-04-16 12:20 ` Michael Heerdegen
2016-04-16 12:31 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Peter Münster @ 2016-04-16 11:39 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 23299
On Sat, Apr 16 2016, Eli Zaretskii wrote:
> Please show a complete recipe for reproducing this problem, starting
> with "emacs -Q".
- emacs -Q
- open /tmp/foo.org
- M-x org-mode
- M-S-return (org-insert-todo-heading)
- C-c C-d (org-deadline)
- go to the time-stamp
- M-x org-timestamp-up-day
--
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
2016-04-16 11:39 ` Peter Münster
@ 2016-04-16 12:20 ` Michael Heerdegen
2016-04-16 12:31 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Michael Heerdegen @ 2016-04-16 12:20 UTC (permalink / raw
To: Peter Münster; +Cc: 23299
Peter Münster <pmlists@free.fr> writes:
> - emacs -Q
> - open /tmp/foo.org
> - M-x org-mode
> - M-S-return (org-insert-todo-heading)
> - C-c C-d (org-deadline)
> - go to the time-stamp
> - M-x org-timestamp-up-day
I saw that, too.
And I got a similar error after hitting t d in the agenda (aka "mark as
done"). After the error happened, the according entry in the todo file
was broken...not good.
Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
2016-04-16 11:39 ` Peter Münster
2016-04-16 12:20 ` Michael Heerdegen
@ 2016-04-16 12:31 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-04-16 12:31 UTC (permalink / raw
To: Peter Münster; +Cc: 23299
> From: Peter Münster <pmlists@free.fr>
> Cc: 23299@debbugs.gnu.org
> Date: Sat, 16 Apr 2016 13:39:09 +0200
>
> On Sat, Apr 16 2016, Eli Zaretskii wrote:
>
> > Please show a complete recipe for reproducing this problem, starting
> > with "emacs -Q".
>
> - emacs -Q
> - open /tmp/foo.org
> - M-x org-mode
> - M-S-return (org-insert-todo-heading)
> - C-c C-d (org-deadline)
> - go to the time-stamp
> - M-x org-timestamp-up-day
Thanks. With this recipe, the problem happens on master, but not on
the emacs-25 branch. This is because encode-time on master no longer
accepts a list of (nil nil nil) as a valid time-zone specification.
That list looks wrong to me, so it sounds like a bug in Org that was
exposed by the recent changes in encode-time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil)
2016-04-19 6:22 org-timestamp-change and timezone Cédric Chépied
@ 2016-04-20 7:11 ` Paul Eggert
0 siblings, 0 replies; 6+ messages in thread
From: Paul Eggert @ 2016-04-20 7:11 UTC (permalink / raw
To: Peter Münster; +Cc: 23299-done, Cédric Chépied
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
Thanks for reporting the problem. As Eli suggested, it was a typo in org.el that
was exposed by recent changes to encode-time. I installed into master the
attached patch, which I think fixes the bug.
[-- Attachment #2: 0001-Fix-org-timestamp-change-typo.txt --]
[-- Type: text/plain, Size: 1201 bytes --]
From 313ebbbb98ceb078468498998305749b2790b7ba Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@penguin.cs.ucla.edu>
Date: Wed, 20 Apr 2016 00:06:01 -0700
Subject: [PATCH] Fix org-timestamp-change typo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Problem reported by Peter Münster (Bug#23299).
* lisp/org/org.el (org-timestamp-change): Fix typo that relied
on undocumented behavior in ‘encode-time’. In practice the
old code used local time, so use that.
---
lisp/org/org.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/org/org.el b/lisp/org/org.el
index 3abf627..b0e1e20 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -17459,8 +17459,7 @@ org-timestamp-change
(+ (if (eq org-ts-what 'hour) n 0) (nth 2 time0))
(+ (if (eq org-ts-what 'day) n 0) (nth 3 time0))
(+ (if (eq org-ts-what 'month) n 0) (nth 4 time0))
- (+ (if (eq org-ts-what 'year) n 0) (nth 5 time0))
- (nthcdr 6 time0)))
+ (+ (if (eq org-ts-what 'year) n 0) (nth 5 time0))))
(when (and (member org-ts-what '(hour minute))
extra
(string-match "-\\([012][0-9]\\):\\([0-5][0-9]\\)" extra))
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-20 7:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-16 9:08 bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil) Peter Münster
2016-04-16 10:57 ` Eli Zaretskii
2016-04-16 11:39 ` Peter Münster
2016-04-16 12:20 ` Michael Heerdegen
2016-04-16 12:31 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2016-04-19 6:22 org-timestamp-change and timezone Cédric Chépied
2016-04-20 7:11 ` bug#23299: 25.1.50; org-timestamp-change: Invalid time zone specification: (nil nil nil) Paul Eggert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.