all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phillip.lord@russet.org.uk (Phillip Lord)
To: Barry Margolin <barmar@alum.mit.edu>
Cc: help-gnu-emacs@gnu.org
Subject: Re: hijack C function, use it transparently with in-between layer
Date: Mon, 06 Jun 2016 12:30:34 +0100	[thread overview]
Message-ID: <87bn3eftb9.fsf@russet.org.uk> (raw)
In-Reply-To: <barmar-5848D2.03324206062016@88-209-239-213.giganet.hu> (Barry Margolin's message of "Mon, 06 Jun 2016 03:32:42 -0400")

Barry Margolin <barmar@alum.mit.edu> writes:

> In article <868tyjnghn.fsf@student.uu.se>,
>  Emanuel Berg <embe8573@student.uu.se> wrote:
>
>> The truth is down there!
>> 
>> (defvar old-message)
>> (fset 'old-message (symbol-function #'message))
>> 
>> (defun message (format-string &rest args)
>>   (unless (member format-string
>>                   '(
>>                     "It was just another system of control."
>>                     "Mark set"
>>                     ))
>>       (apply `(old-message ,format-string ,@args) )))
>> 
>> ;; test:
>> ;;
>> ;;  (message "%s - %s" "1" "2")
>> ;;  (message "Break on thru to the other side.")
>> ;;  (message "It was just another system of control.")
>> ;;  (message "Mark set")
>
> Shouldn't you do this using advice?


Advice only works partially (as I expect this will). The message
function is also called directly in the C layer. Advice will not capture
those cases.

Phil



  parent reply	other threads:[~2016-06-06 11:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  3:28 hijack C function, use it transparently with in-between layer Emanuel Berg
2016-06-06  3:46 ` Marcin Borkowski
2016-06-06  7:32 ` Barry Margolin
2016-06-06 10:55   ` Emanuel Berg
2016-06-06 11:30   ` Phillip Lord [this message]
     [not found]   ` <mailman.967.1465212644.1216.help-gnu-emacs@gnu.org>
2016-06-06 11:51     ` Emanuel Berg
2016-06-06 13:12       ` Stefan Monnier
     [not found]       ` <mailman.971.1465218784.1216.help-gnu-emacs@gnu.org>
2016-06-06 13:30         ` Emanuel Berg
2016-06-06 13:58           ` Stefan Monnier
     [not found]           ` <mailman.974.1465221532.1216.help-gnu-emacs@gnu.org>
2016-06-06 14:42             ` Barry Margolin
2016-06-06 14:58               ` Stefan Monnier
2016-06-06 23:03               ` Emanuel Berg
2016-06-06 23:44                 ` Barry Margolin
2016-06-07  1:12                   ` Emanuel Berg
2016-06-06 23:49                 ` John Mastro
     [not found]                 ` <mailman.1031.1465256987.1216.help-gnu-emacs@gnu.org>
2016-06-07  1:08                   ` Emanuel Berg
2016-06-07 11:12                 ` Phillip Lord
2016-06-07 15:22                   ` Eli Zaretskii
2016-06-07 17:05                   ` Emanuel Berg
     [not found]                 ` <mailman.1050.1465298004.1216.help-gnu-emacs@gnu.org>
2016-06-07 12:00                   ` Emanuel Berg
2016-06-06 14:40     ` Barry Margolin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bn3eftb9.fsf@russet.org.uk \
    --to=phillip.lord@russet.org.uk \
    --cc=barmar@alum.mit.edu \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.