From: Ted Zlatanov <tzz@lifelogs.com>
To: Konstantin Kliakhandler <kosta@slumpy.org>
Cc: 23759@debbugs.gnu.org, Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#23759: 25.1.50; 25.1.50; open-tls-stream creates malformed gnutls-cli command if trusted cert files don't exist
Date: Fri, 08 Jul 2016 09:43:35 -0400 [thread overview]
Message-ID: <87bn28b5yw.fsf@lifelogs.com> (raw)
In-Reply-To: <CAH+LVpnc3EyQT_MjUiKoH5iDLRu=_qyp3dkyGxAvT0VXYSY5mg@mail.gmail.com> (Konstantin Kliakhandler's message of "Fri, 8 Jul 2016 01:40:13 +0300")
On Fri, 8 Jul 2016 01:40:13 +0300 Konstantin Kliakhandler <kosta@slumpy.org> wrote:
T> Perhaps there can be a way to say
T> "if this %t is empty, remove the preceding --argument as well"
T> in the format string? That would simplify the whole thing, like so:
T> "gnutls-cli --x509cafile %T -p %p %h"
T> ...becomes "gnutls-cli -p PORT HOST"
T> when the %T parameter is nil. Just an idea...
KK> I toyed with this idea, and even implemented something of the sort, but
KK> from a bit different different direction - I added another replacement
KK> variable - %c - and made the list tls-program now contain pairs with
KK> (string . value-of-c), e.g. ("gnutls-cli %c %T -p %p %h" . "--x509cafile")
KK> have both %c and %T replaced (together) as appropriate.
KK> The problem with this approach is, what about people who customized this
KK> setting? So, I made it backward compatible with the old standard.
KK> Eventually however, it turned into a an ugly big mess due to the backward
KK> compatability and I decided against submitting.
KK> There is a similar problem of backward compatibility in your approach -
KK> what if someone customized it in such a way that wasn't expecting an
KK> argument to be removed, and it would create a vulnerability in their setup?
KK> I also don't see a simple way to do it nicely, but have no objections on
KK> those grounds, of course.
Hmm, right, yeah... well %t is always preceded by an argument, right? So
maybe the backwards-compatible solution is that if %t is nil, delete the
preceding option?
Another option is to throw an error when %t is nil, explaining what
happened and how to fix it. That's not a terrible inconvenience for the
user, compared to running an insecure connection unknowingly. I slightly
prefer this.
KK> Finally, I would do the patch but am uncertain whether it would be better
KK> to wait for your results from emacs-devel and remove the ssl3 bit as well
KK> (or just go ahead and do it). Let me know and I'll send the appropriate
KK> patch.
Go ahead and remove it, we have agreement that it's a Bad Thing. Thank you!
Ted
next prev parent reply other threads:[~2016-07-08 13:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 21:32 bug#23759: 25.1.50; open-tls-stream creates malformed gnutls-cli command if trusted cert files don't exist Francis Litterio
2016-06-13 3:42 ` Eli Zaretskii
2016-06-13 10:18 ` Lars Ingebrigtsen
[not found] ` <CAGQpP8QFu3zx9_3SLf5tVRhGC7bV0hUiA8=OJm8HpA5H-hTfwA@mail.gmail.com>
[not found] ` <CAGQpP8QWYaxgE0=VGshhxDW=U3yT_kXsNq178m6zPGq15Ets9g@mail.gmail.com>
2016-06-13 11:33 ` Fran
2016-06-13 11:40 ` Lars Ingebrigtsen
2016-06-13 11:49 ` Fran
2016-06-13 14:03 ` Eli Zaretskii
2016-07-02 0:09 ` bug#23759: 25.1.50; Konstantin Kliakhandler
2016-07-02 7:09 ` bug#23759: 25.1.50; 25.1.50; open-tls-stream creates malformed gnutls-cli command if trusted cert files don't exist Konstantin Kliakhandler
2016-07-05 14:36 ` Ted Zlatanov
2016-07-05 14:49 ` Noam Postavsky
2016-07-05 16:54 ` Konstantin Kliakhandler
2016-07-05 17:59 ` Noam Postavsky
2016-07-05 21:17 ` Ted Zlatanov
2016-07-06 22:24 ` Richard Stallman
2016-07-07 3:31 ` Ted Zlatanov
2016-07-07 6:11 ` Konstantin Kliakhandler
2016-07-07 22:01 ` Richard Stallman
2016-07-07 17:10 ` Ted Zlatanov
2016-07-07 22:40 ` Konstantin Kliakhandler
2016-07-08 13:43 ` Ted Zlatanov [this message]
2019-05-13 19:42 ` bug#23759: " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn28b5yw.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=23759@debbugs.gnu.org \
--cc=kosta@slumpy.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.