From: Michael Albinus <michael.albinus@gmx.de>
To: Dima Kogan <dima@secretsauce.net>
Cc: 23952@debbugs.gnu.org
Subject: bug#23952: 25.0.95; Regression: vc (git) over TRAMP doesn't work anymore
Date: Tue, 12 Jul 2016 09:43:58 +0200 [thread overview]
Message-ID: <87bn23cncx.fsf@gmx.de> (raw)
In-Reply-To: <87y4572z6m.fsf@secretsauce.net>
Dima Kogan <dima@secretsauce.net> writes:
> Hi.
Hi,
> I'm running a very recent emacs built from git (658daf9). In the
> last two weeks or so, remote VC mode stopped working. Recipe:
>
> 1. emacs -Q
> 2. C-x C-f /127.0.0.1:emacs (or any other remote path that has a git
> repo)
> 3. C-x C-v D (or any other VC-mode function)
>
> Instead of seeing VC mode do its thing it now throws an error:
>
> env: ‘GIT_DIR’: No such file or directory
This is due to Bug#23769, adding "GIT_DIR" to `process-environment'.
Tramp handles properly entries like "key=value" and "key=", entries like
"key" are not handled properly yet.
The following patch towards the emacs-25 branch fixes this:
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs-25/lisp/net/tramp-sh.el.~f981b3136742a8597674dd4915afeb1b220a0464~ 2016-07-12 09:41:08.663542129 +0200
--- /home/albinus/src/emacs-25/lisp/net/tramp-sh.el 2016-07-12 09:41:03.843470688 +0200
***************
*** 3034,3040 ****
(cons prompt (nreverse (copy-sequence process-environment)))
env)
(or (member elt (default-toplevel-value 'process-environment))
! (setq env (cons elt env)))))
(command
(when (stringp program)
(format "cd %s && exec %s env %s %s"
--- 3034,3043 ----
(cons prompt (nreverse (copy-sequence process-environment)))
env)
(or (member elt (default-toplevel-value 'process-environment))
! (setq env
! (if (string-match "=" elt)
! (append env `(,elt))
! (append `("-u" ,elt) env))))))
(command
(when (stringp program)
(format "cd %s && exec %s env %s %s"
***************
*** 3135,3141 ****
(setq env
(dolist (elt (nreverse (copy-sequence process-environment)) env)
(or (member elt (default-toplevel-value 'process-environment))
! (setq env (cons elt env)))))
(when env
(setq command
(format
--- 3138,3147 ----
(setq env
(dolist (elt (nreverse (copy-sequence process-environment)) env)
(or (member elt (default-toplevel-value 'process-environment))
! (setq env
! (if (string-match "=" elt)
! (append env `(,elt))
! (append `("-u" ,elt) env))))))
(when env
(setq command
(format
--8<---------------cut here---------------end--------------->8---
Should this be pushed to the emacs-25 branch, or to master?
Best regards, Michael.
next prev parent reply other threads:[~2016-07-12 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 5:38 bug#23952: 25.0.95; Regression: vc (git) over TRAMP doesn't work anymore Dima Kogan
2016-07-12 7:43 ` Michael Albinus [this message]
2016-07-12 7:49 ` Eli Zaretskii
2016-07-12 7:52 ` Andreas Schwab
2016-07-12 14:53 ` Michael Albinus
2016-07-12 15:07 ` Eli Zaretskii
2016-07-12 15:37 ` Michael Albinus
2016-07-12 16:08 ` Dima Kogan
2016-07-12 17:47 ` Eli Zaretskii
2016-07-12 18:15 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn23cncx.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=23952@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.