From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Joost Kremers Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 11:28:31 +0200 Message-ID: <87bn21nayo.fsf@fastmail.fm> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468402175 19762 80.91.229.3 (13 Jul 2016 09:29:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 09:29:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 11:29:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNGTt-0007Jo-3a for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 11:29:25 +0200 Original-Received: from localhost ([::1]:46179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNGTr-0007e1-UX for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 05:29:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNGTK-0007VS-VD for emacs-devel@gnu.org; Wed, 13 Jul 2016 05:28:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNGTG-0006v7-JO for emacs-devel@gnu.org; Wed, 13 Jul 2016 05:28:50 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNGTE-0006ru-5A for emacs-devel@gnu.org; Wed, 13 Jul 2016 05:28:46 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1A68D20687; Wed, 13 Jul 2016 05:28:34 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Wed, 13 Jul 2016 05:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=rGT2oWL+2H67gbGu YITvLWgjUlc=; b=bKEP4yE5uK4zIZaxP0eAdeUrHTQuRW3med2ZabA31dW/1R6u wLJIjR5Kxjp5O+e1LVN894vdIEsWZau5Vqbx9hW7aEG0OCnuz4xALjuYXO8nOjJB 8CZ520iRKsVp6qO0Qutq5mJ+gGllo2xo1RjNwXW66Daf1AfYNd1yQ/eW/no= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-sasl-enc:x-sasl-enc; s= smtpout; bh=rGT2oWL+2H67gbGuYITvLWgjUlc=; b=rTkSKrAjHPTcps3BEAR0 QexNW74/tuwSZPJIqZnvSA6Rso9ZqwXBsul1JYQY7SmLvbs31fcUMkeJyszP8R3J HQ/nx+Ls8e6uiSVh05eClNMWLaeepSC0g8hbDPZHqp3OrCyrHVAMaoSTgpNApRe2 qKIDiVxBLGkDkHknLL3h46k= X-Sasl-enc: 3VapAjcxKKtEsEI+fHc6+c5n7UWJj8G7NGHFPagpXxna 1468402113 Original-Received: from IdeaPad.messagingengine.com (eruc064.goemobile.de [134.76.38.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 6650DF29F5; Wed, 13 Jul 2016 05:28:33 -0400 (EDT) User-agent: mu4e 0.9.17; emacs 25.0.94.1 In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205616 Archived-At: On Tue, Jul 12 2016, Stefan Monnier wrote: > EZ> Unlike Stefan, I think we should add :group to every defcustom. Having > EZ> them mysteriously missing from some of them is a time bomb: > > The way I see it, defcustoms should pretty much never have :group, and > the group to which they belong is simply determined by the file in which > they occur. That would mean that in multifile packages the defcustoms must always be put in one single file, which must be named according to the customisation group one wants to create. And creating multiple customisaton groups for a single package (not uncommon in larger packages) would require multiple files. That's to say, such a system would require that the code of a package be organised along the lines of the customisation groups it provides. But customisation is a UI feature, and as such does not necessarily present the best way to organise the code. -- Joost Kremers Life has its moments