From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Mon, 15 Aug 2016 18:46:19 +0200 Message-ID: <87bn0u3rqc.fsf@linux-m68k.org> References: <8337m7h1dp.fsf@gnu.org> <83zioffew5.fsf@gnu.org> <83popaf1yz.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471279641 18436 195.159.176.226 (15 Aug 2016 16:47:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Aug 2016 16:47:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: p.stephani2@gmail.com, Paul Eggert , nicolas@petton.fr, johnw@gnu.org, 24206@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 15 18:47:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZL2h-0004Uj-O4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Aug 2016 18:47:15 +0200 Original-Received: from localhost ([::1]:38054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZL2e-0002aU-Ok for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Aug 2016 12:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZL2Y-0002aE-66 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2016 12:47:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZL2U-0002EK-Ql for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2016 12:47:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZL2U-0002EG-N3 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2016 12:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bZL2U-0000Vv-FH for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2016 12:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2016 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24206-submit@debbugs.gnu.org id=B24206.14712795901933 (code B ref 24206); Mon, 15 Aug 2016 16:47:02 +0000 Original-Received: (at 24206) by debbugs.gnu.org; 15 Aug 2016 16:46:30 +0000 Original-Received: from localhost ([127.0.0.1]:58489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZL1t-0000V3-DC for submit@debbugs.gnu.org; Mon, 15 Aug 2016 12:46:30 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:46602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZL1r-0000Uv-QV for 24206@debbugs.gnu.org; Mon, 15 Aug 2016 12:46:24 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3sChG60Bf6z3hjkb; Mon, 15 Aug 2016 18:46:21 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3sChG536XgzvkRh; Mon, 15 Aug 2016 18:46:21 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id KzIoZgKZXTlq; Mon, 15 Aug 2016 18:46:20 +0200 (CEST) X-Auth-Info: LkibYMw6U2acMQQChkgKdNQtcK9zM0Z9LxUXLguPBFpuZ20Mm70t/hEscKbwBfOy Original-Received: from igel.home (ppp-88-217-19-168.dynamic.mnet-online.de [88.217.19.168]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 15 Aug 2016 18:46:20 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id EDF552C3764; Mon, 15 Aug 2016 18:46:19 +0200 (CEST) X-Yow: Why are these athletic shoe salesmen following me?? In-Reply-To: <83popaf1yz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Aug 2016 19:09:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122245 Archived-At: On Aug 15 2016, Eli Zaretskii wrote: > I'm not sure. We never discussed what should Emacs do when > substitute-command-keys is called on a unibyte non-ASCII string which > requires quote substitution. Unibyte strings should not be used for anything but pre-decoding / post-encoding situations directly after / before doing the actual I/O operation. Thus substitute-command-keys should never be called with an undecoded unibyte string. IMHO it would be ok to return something useless in this case (but it shouldn't cause Emacs to crash, of course). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."