From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#24313: [PATCH] Add tests for dom.el Date: Sat, 27 Aug 2016 12:07:13 +0200 Message-ID: <87bn0e4jam.fsf@gmx.de> References: <1472235970.16843.0@smtp.gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1472292503 21576 195.159.176.226 (27 Aug 2016 10:08:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2016 10:08:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: larsi@gnus.org, 24313@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 27 12:08:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdaXB-0004zf-2d for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 12:08:17 +0200 Original-Received: from localhost ([::1]:35317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdaX6-0002bI-Pa for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 06:08:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdaX1-0002Wb-9f for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 06:08:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdaWw-0000gY-4R for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 06:08:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdaWw-0000gS-1Q for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 06:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdaWv-0001P1-RB for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 06:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.14722924445345 (code B ref 24313); Sat, 27 Aug 2016 10:08:01 +0000 Original-Received: (at 24313) by debbugs.gnu.org; 27 Aug 2016 10:07:24 +0000 Original-Received: from localhost ([127.0.0.1]:41859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdaWJ-0001O8-Sh for submit@debbugs.gnu.org; Sat, 27 Aug 2016 06:07:24 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:49193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdaWJ-0001Nw-2o for 24313@debbugs.gnu.org; Sat, 27 Aug 2016 06:07:23 -0400 Original-Received: from detlef.gmx.de ([87.146.60.197]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LzXTy-1b0aen3bd4-014gTl; Sat, 27 Aug 2016 12:07:16 +0200 In-Reply-To: <1472235970.16843.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Fri, 26 Aug 2016 20:26:10 +0200") X-Provags-ID: V03:K0:XFKN3oD/kkZ6+bR9Ud/PZeg5v0PLNp9CFUhqAOBswxSyJ3RHuf5 MWo9OGNz5L2RRgX21mSRQIZ36VWTwIhmri9JR/fok2jezVc9a6hwYUQ1ETZkSY3B+Xd3/qK m5Kb5Cjsm4Z0+E9l5ONn8NprjkoLuySb+rlnNp1F3iTMMkC71VPOlEjmtvVr61ZKz+uI0BR GC167TxhfD7fNJTeAF8kQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ulZofb367IQ=:Q92VgnYIiVrYHwYs0jUliy RRF61kBHmPkpF+izXf3fK+X2JTbLdJAdNHTFETCVuuXIQgyvtGhD2I0yioInLrAL5HEZw2XLn NGTDHZdRytmcXFI9OZF6QTJO2j7lbr4Baza+ynlTdFdlghutSjgWpfEfypsVrqD7Lw/p2UNvC z6CnkeZE8Z4HJQ7IXylqYRPueYTYmarMQgBR3UExpAY8ARr3oEtFgx/k64GA4IXVd+LMsC9WO Z3rq8+xmd2sbSOr911H5T2Ei/Yzznf460haLRywX4EFAztvwAGGitaakfS6xg5QZZOO5t8b3a U+5AEjek43Loux5pOsSXFTyYNfr1njbAEpn51w1Vjy3aFxNdcoHMXmYXKGRkPU2+NKTT+bqHv gpsEZ/iv7ejfiy5elMiw4+HFqQqgCs/lKfrKSM3yvRDhJYiXUKRSqH6tacAREJ1iHrRFbth/g 1HNm4K+GsANBTLzubGVQAzDLkJb6PrsoSKdQGbwr1d8PoFfvAhMEPfBTL5JcRj3joAPxVP/YS klj946E58AGRpkua6LB74OMeXbomepQjqgHpgqgsmvh5G/9X6KW4KrYT1mHvOge5bVIQ+tj72 FmbhSXAlcFW7eNcMdEv2vYW5o6h9aX4csEaTO+a4oTwoXE8JFXiWSz1SkcHHIV9s8uhs9Dgat 1F3z+khO+M2pC/dZri1wpOmmNfB9zj30Dm2Z80N3uyFzA1FTuwpIkLvYc+8mZhB3GzLZuWESb mpmSv13mjvghTvS4tJt1AwU5VRNFqkEX7RKgO+5sxUbKWdI92uXXlm2S+FMz2q2o7krdvmn9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122718 Archived-At: Simen Heggest=C3=B8yl writes: > Hello, Hi Simen, > I saw that dom.el didn't have any tests, so I wrote some. > > Do they look okay to add? > > +;;; dom-tests.el --- Tests for dom.el -*- lexical-binding: t; -*- > + > +(ert-deftest test-dom-tag () Pls start all tests with the name of the package, "dom-tests-*". It would also be nice if you could add a docstring per test. > + (should (null (dom-attributes dom))) This reads better as (should-not (dom-attributes dom)) Best regards, Michael.