From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] I regret using subtree Date: Sun, 12 Mar 2017 19:18:38 -0700 Message-ID: <87bmt5udfl.fsf@ericabrahamsen.net> References: <87lh1d2wg5.fsf@russet.org.uk> <83eg75jk5h.fsf@gnu.org> <87lh1cb6p0.fsf@lifelogs.com> <87oa5sa176.fsf_-_@lifelogs.com> <874m7kmkcm.fsf@gmx.de> <871t2o6t94.fsf@gmx.de> <87wpkf6pup.fsf@lifelogs.com> <87poq6iweb.fsf@ericabrahamsen.net> <87shv0uy3w.fsf@ericabrahamsen.net> <87oa5ouf6x.fsf@ericabrahamsen.net> <87y44qu40k.fsf@ericabrahamsen.net> <87twfetz6s.fsf@ericabrahamsen.net> <87innet48i.fsf_-_@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1489371594 25461 195.159.176.226 (13 Mar 2017 02:19:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Mar 2017 02:19:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 13 03:19:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnFaM-0005d1-AH for ged-emacs-devel@m.gmane.org; Mon, 13 Mar 2017 03:19:46 +0100 Original-Received: from localhost ([::1]:49758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnFaQ-0007fn-Mo for ged-emacs-devel@m.gmane.org; Sun, 12 Mar 2017 22:19:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnFZm-0007fh-FB for emacs-devel@gnu.org; Sun, 12 Mar 2017 22:19:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnFZj-0005mY-BL for emacs-devel@gnu.org; Sun, 12 Mar 2017 22:19:10 -0400 Original-Received: from [195.159.176.226] (port=60882 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnFZj-0005m3-3x for emacs-devel@gnu.org; Sun, 12 Mar 2017 22:19:07 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cnFZW-0000aZ-Qc for emacs-devel@gnu.org; Mon, 13 Mar 2017 03:18:54 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 102 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:/YYt1YFtVCb/h2J8xTqpdb7XThA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212973 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >> Okay, I officially regret having used the subtree approach to squash >> Gnorb into Elpa, and if at all possible I would like to abandon this and >> move to just working in the Elpa tree. >> Do I have to do anything magic? My understanding of the `git subtree' >> command is that it isn't actually a "real" command, it's just some >> behind-the-scenes jiggery-pokery with merge and cherry-pick and >> read-tree. Ie, I should just be able to declare "I'm done with this" and >> carry on making commits directly into Elpa. Is that correct? > > That is correct. > [ Of course, if you want, you can also "git rm -r packages/gnorb" and > then add an externals/gnorb branch. ] No, I think I'll go with the simpler option. >> The only thing I'll regret is the github issue tracker, and for that >> reason I'm tacking this on to a thread from last year, about making >> `report-emacs-bug' collect package information before sending a bug >> report, and cc'ing maintainers. I still think this is a good idea, and I >> think my patch, if not ideal, is good enough, so I'm reviving it. What >> say you all? > > The patch seems OK, except it should put the Cc in the "X-Debbugs-Cc:" > header (so that the maintainer gets the email with the bug-number > rather than email before assigned a bug-number). Here's an updated version. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Prompt-for-package-when-reporting-emacs-bug.patch >From 51cd6dd13b965453b56526e6f323fd563b7ed026 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sun, 12 Mar 2017 18:41:42 -0700 Subject: [PATCH] Prompt for package when reporting emacs bug * lisp/mail/emacsbug.el (report-emacs-bug): Prompt for a package, and put the package maintainer in the X-Debbugs-Cc header. --- lisp/mail/emacsbug.el | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index c1aec6923f..656eeabe0f 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -123,17 +123,26 @@ message-send-mail-function (defvar message-sendmail-envelope-from) ;;;###autoload -(defun report-emacs-bug (topic &optional unused) +(defun report-emacs-bug (topic package &optional unused) "Report a bug in GNU Emacs. Prompts for bug subject. Leaves you in a mail buffer." (declare (advertised-calling-convention (topic) "24.5")) - (interactive "sBug Subject: ") + (interactive (list + (read-string "Bug Subject: ") + (completing-read + "Package: " + (progn + (package-initialize) + package-alist)))) ;; The syntax `version;' is preferred to `[version]' because the ;; latter could be mistakenly stripped by mailing software. (setq topic (concat emacs-version "; " topic)) (let ((from-buffer (current-buffer)) (can-insert-mail (or (report-emacs-bug-can-use-xdg-email) (report-emacs-bug-can-use-osx-open))) + (cc (unless (or (string-empty-p package) (string= package "emacs")) + (require 'finder) + (lm-maintainer (find-library-name package)))) user-point message-end-point) (setq message-end-point (with-current-buffer (messages-buffer) @@ -160,6 +169,13 @@ report-emacs-bug (when (and (not message-sendmail-envelope-from) (message-bogus-recipient-p (message-make-address))) (set (make-local-variable 'message-sendmail-envelope-from) 'header))) + (when (cdr cc) ;; cdr is the email address. + (if (eq major-mode 'message-mode) + (message-position-on-field "X-Debbugs-Cc") + (mail-cc)) + (if (car cc) + (insert (format "%s <%s>" (car cc) (cdr cc))) + (insert (format "%s" (cdr cc))))) (rfc822-goto-eoh) (forward-line 1) ;; Move the mail signature to the proper place. -- 2.12.0 --=-=-=--