bug#26037: 25.1; perl-mode add syntax support for subroutine signatures

[npostavs@users.sourceforge.net]

[-- Attachment #1: Type: text/plain, Size: 60 bytes --]

[Please use Reply All to keep 26037@debbugs.gnu.org on CC]


[-- Attachment #2: Type: message/rfc822, Size: 2671 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 859 bytes --]

OK, I see.

After a bit of testing with C-u C-x =, I see that with my proposed
change the sigils in 'sub test ($)' will *not* have punctuation class
as they did before the chagne.

I see these options:

1. I can try to improve the proposed change to preserve backward
compatibility - I can try to add another rule which will strictly
match only the allowed prototype-sigils $%&*;@[\]

2. discard my proposed change as it might have undesired side effects -
at this point, I don't see anything in perl-mode which depends on
these prototype-sigils having punctioation class, however, I could be
missing something.

3. accept my proposed change as-is, but we must be sure nothing will
be broken as a result.  I'm sure syntax highlighting will not be
broken (I've tested with different themes, different perl sub
definitions).

Please let me know what you think.

[-- Attachment #3: Type: text/plain, Size: 190 bytes --]



I ran git blame against the relevant lines, and turned up Bug#18502.
Please check if your change breaks the indentation test case at
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18502#5.