all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25942@debbugs.gnu.org
Subject: bug#25942: 26.0.50; dired-mark-extension prepend '.' to suffix if not present
Date: Mon, 27 Mar 2017 01:40:28 +0300	[thread overview]
Message-ID: <87bmsn1x2d.fsf@localhost> (raw)
In-Reply-To: <87d1dzjadq.fsf@calancha-pc> (Tino Calancha's message of "Fri, 03 Mar 2017 12:40:33 +0900")

> emacs -Q /tmp
>
> (require 'dired-x)
> (require 'ert)
> ;; Evaluate following sexp:
> (let ((dirs '("Public" "Music"))
>       (files '(".bashrc" "bar.c" "foo.c"))
>       (dir (make-temp-file "Bug25942" 'dir)))
>   (unwind-protect
>       (progn
>         (dolist (d dirs)
>           (make-directory (expand-file-name d dir)))
>         (dolist (f files)
>           (write-region nil nil (expand-file-name f dir)))
>         (dired dir)
>         (dired-mark-extension "c")
>         (should (= 2 (length (dired-get-marked-files)))))
>     (delete-directory dir 'recursive)))
>
> IMO, in this example looks better if just those files ending with
> '.c' are marked i.e., to not mark 'Public' or 'Music'.

Is this a backward-compatible change?  If not, then maybe better
prepend ‘.’ only to the default value for interactive uses?  So users
will get the right result when using ‘M-x dired-mark-extension RET RET’.
But for the programmatic uses it's the responsibility of the caller to
supply the right suffix in ‘(dired-mark-extension ".c")’





  reply	other threads:[~2017-03-26 22:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  3:40 bug#25942: 26.0.50; dired-mark-extension prepend '.' to suffix if not present Tino Calancha
2017-03-26 22:40 ` Juri Linkov [this message]
2017-03-27  1:30   ` Tino Calancha
2017-03-27  1:32     ` Tino Calancha
2017-03-27  2:35     ` Eli Zaretskii
2017-03-27  5:34       ` Tino Calancha
2017-03-27 14:28         ` Eli Zaretskii
2017-03-27 15:32           ` Tino Calancha
2017-03-27 22:44         ` Juri Linkov
2017-03-28  1:23           ` Tino Calancha
2017-03-31  8:34             ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmsn1x2d.fsf@localhost \
    --to=juri@linkov.net \
    --cc=25942@debbugs.gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.