Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

[Laurence Rochfort]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

If you change the TODO state with org-todo and it accepts a message, but
you then cancel the message with C-c C-k, org does not revert the TODO
heading to its previous state.

For instance:

Heading is TODO
C-c C-t -> Set to WORKING
Prompted for message
Cancel with C-c C-k
TODO heading still says working; it has not reverted to TODO.

I would expect cancelling the message to revert the TODO heading, but
instead I have to "undo" with C-/.


Emacs  : GNU Emacs 25.1.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.20.9)
 of 2016-10-13
Package: Org mode version 9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)

current state:
==============
(setq
 org-hide-leading-stars t
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-finalize-agenda-hook '(org-agenda-property-add-properties)
 org-default-notes-file "/home/laurence/Documents/org-mode/notes.org"
 org-capture-templates '(("b" "Bugs")
			 ("bc" "Customer bugs" entry (file+headline "/home/laurence/Documents/org-mode/work.org" "Customer Bugs") "* TODO %^L %^C %^g %?")
			 ("bi" "Internal bugs" entry (file+headline "/home/laurence/Documents/org-mode/work.org" "Internal Bugs") "* TODO %^L %^C %^g %?"))
 org-startup-indented t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-from-is-user-regexp "\\<Laurence Rochfort\\>"
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-block-all append local] 5]
		 #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec
		 org-babel-hide-all-hashes (closure (t) nil (org-bullets-mode 1)) (closure (t) nil (flyspell-mode)))
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-enforce-todo-dependencies t
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
 org-agenda-finalize-hook '(org-agenda-property-add-properties)
 org-todo-keywords '((sequence "TODO(t/!)" "IN-PROGRESS(p/!)" "WAITING ON CUSTOMER(w@/@)" "READY FOR QA(r/!)" "SUBMITTED FOR QA(q/!)" "|" "ON-HOLD(h/@)"
		      "DONE(d/!)" "CANCELLED(c/@)" "CLOSED(l/@)" "NOT A BUG(n/@)" "DUPLICATE BUG(u@/!)" "SUBMITTED FOR RELEASE(b@/!)" "DELIVERED(v/!)"
		      "PR ACCEPTED(a@/!)")
		     )
 org-modules '(org-bbdb org-bibtex org-docview org-gnus org-info org-irc org-mhe org-rmail org-w3m org-mac-iCal org-mac-link)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-log-into-drawer t
 org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
 org-link-parameters '(("id" :follow org-id-open) ("x-devonthink-item" :follow org-devonthink-item-open)
		       ("mac-evernote" :follow org-mac-evernote-note-open) ("mac-outlook" :follow org-mac-outlook-message-open)
		       ("acrobat" :follow org-mac-acrobat-open) ("skim" :follow org-mac-skim-open) ("addressbook" :follow org-mac-addressbook-item-open)
		       ("x-together-item" :follow org-mac-together-item-open) ("w3m" :store org-w3m-store-link)
		       ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store org-irc-store-link)
		       ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
		       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
		       ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
		       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
		       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link)
		       ("mu4e" :follow org-mu4e-open :store org-mu4e-store-link) ("file+sys") ("file+emacs") ("doi" :follow org--open-doi-link)
		       ("elisp" :follow org--open-elisp-link) ("file" :complete org-file-complete-link)
		       ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path)))) ("help" :follow org--open-help-link)
		       ("http" :follow (lambda (path) (browse-url (concat "http:" path))))
		       ("https" :follow (lambda (path) (browse-url (concat "https:" path))))
		       ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path)))) ("message" :follow org-mac-message-open)
		       ("news" :follow (lambda (path) (browse-url (concat "news:" path)))) ("shell" :follow org--open-shell-link))
 org-babel-load-languages '((sql . t))
 org-agenda-files '("~/Documents/org-mode/work.org")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

Re: Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

[Nicolas Goaziou]

Hello,

Laurence Rochfort <laurence.rochfort@oracle.com> writes:

> If you change the TODO state with org-todo and it accepts a message, but
> you then cancel the message with C-c C-k, org does not revert the TODO
> heading to its previous state.
>
> For instance:
>
> Heading is TODO
> C-c C-t -> Set to WORKING
> Prompted for message
> Cancel with C-c C-k
> TODO heading still says working; it has not reverted to TODO.
>
> I would expect cancelling the message to revert the TODO heading, but
> instead I have to "undo" with C-/.

I disagree. You may want to cancel the message because this change
doesn't require one, but, yet, want the todo state change.

Having to undo one more time seems a satisfying solution.

Regards,

-- 
Nicolas Goaziou

Re: Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

[Laurence Rochfort]

Nicolas Goaziou writes:

> I disagree. You may want to cancel the message because this change
> doesn't require one, but, yet, want the todo state change.

I see, that makes sense.

I notice that supplying an empty message with C-c C-k results in no
logbook entry at all. Is that intended behaviour too?

Cheers,
Laurence.

Re: Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

[Nicolas Goaziou]

Hello,

Laurence Rochfort <laurence.rochfort@oracle.com> writes:

>> I disagree. You may want to cancel the message because this change
>> doesn't require one, but, yet, want the todo state change.
>
> I see, that makes sense.
>
> I notice that supplying an empty message with C-c C-k results in no
> logbook entry at all. Is that intended behaviour too?

It doesn't sound nonsensical. What would you expect instead ?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Canceling a TODO state change does not revert the heading [9.0.5 (9.0.5-elpa @ /home/laurence/.emacs.d/elpa/org-20170210/)]

[Nicolas Goaziou]

Hello,

Laurence Rochfort <laurence.rochfort@oracle.com> writes:

> I notice that supplying an empty message with C-c C-k results in no
> logbook entry at all. Is that intended behaviour too?

C-c C-k is supposed to cancel note taking, so I guess it is.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738