From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el Date: Tue, 04 Jul 2017 13:49:27 -0600 Message-ID: <87bmp0c794.fsf@lylat> References: <87zicmxdyl.fsf@lylat> <87o9t1c0vm.fsf@calancha-pc> <874luti81g.fsf@lylat> <87wp7oaj3l.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499197822 2668 195.159.176.226 (4 Jul 2017 19:50:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 19:50:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 27559@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 04 21:50:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSTpt-000081-Qo for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 21:50:14 +0200 Original-Received: from localhost ([::1]:42790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSTpx-0006HD-HI for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 15:50:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSTpn-0006Fl-Hj for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 15:50:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSTpi-0003M5-Iu for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 15:50:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSTpi-0003Lz-F3 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 15:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSTpi-0003WL-59 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 15:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2017 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27559-submit@debbugs.gnu.org id=B27559.149919777813499 (code B ref 27559); Tue, 04 Jul 2017 19:50:02 +0000 Original-Received: (at 27559) by debbugs.gnu.org; 4 Jul 2017 19:49:38 +0000 Original-Received: from localhost ([127.0.0.1]:52493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSTpK-0003Ve-Kg for submit@debbugs.gnu.org; Tue, 04 Jul 2017 15:49:38 -0400 Original-Received: from mail-io0-f195.google.com ([209.85.223.195]:36091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSTpJ-0003VS-I8 for 27559@debbugs.gnu.org; Tue, 04 Jul 2017 15:49:38 -0400 Original-Received: by mail-io0-f195.google.com with SMTP id h134so12066931iof.3 for <27559@debbugs.gnu.org>; Tue, 04 Jul 2017 12:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Dg1zP1V2nC+V+96voo5kZ08rg35dlrDg/3jQ9h7/kSA=; b=fJl5bfONuHG5uQboBI2O8GKmAgYaOidRMSmrVWXDanDeaJI5xmB3OIMACLa8fD3c6t agV+J/CUlLF+YCFLqfwsnk+vh0uZqSWl/3jZ8ttzM2C7J6TCZ5N067C4VoaEHYUTKohx YbvyKlpz2PXDdcLV5WMNX8VLbIThVavx7198bNKRK4sd31QQS6vBooQ3BYevLDD4EqYy ASr44E8DIv6xOyg052qRBLnQcwnIJ6/fucdUPcwswgcoqWbOC1QH5nPhct0trfKi70vX NSkIhCUh0MT2sgNEinOuUpdz/2EyaSTDBNTC4Agt6AbjoM93pnM+G8KcIofg/41DmT8J +uEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Dg1zP1V2nC+V+96voo5kZ08rg35dlrDg/3jQ9h7/kSA=; b=geZBr/tZv/CQEIIWcS/Uiem92uh4t8wxIWs/jQW8rLB3W6qu7bVvSRKrvPP1+xFCz2 x2iiKDLg4vq5yaouLpfV72Z2ry3HQuphOZgackeb4Ftj6WRHFlbmUYMpMeLsJASlnEQS RjU44kWtyu7+6UdHB81fhUUYJ/7UetpQrCLcO6OjRyslXwZG0B4Lz1gRt0GNjQCv/WpY CKWVh/qL8XC3fSptGNqkJIAf3NSx0S1FGXk/nRHYvgfSSi6XNhiipkjM+4wN093A68SY +2iwbXKA6wivxPTBZnz//+Aps+3u2bgjdPrqnWjbuxZVxY38KEHL9NMwT4s6em3VEZat ymlw== X-Gm-Message-State: AKS2vOy6SDfmns0OBdSVIYy76/1YMgmMuJybaDH68qDVHqJI0aJkCxky UMk5MPa3pevy9CSw X-Received: by 10.107.16.81 with SMTP id y78mr45067025ioi.105.1499197771462; Tue, 04 Jul 2017 12:49:31 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id 9sm6973118iop.9.2017.07.04.12.49.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jul 2017 12:49:30 -0700 (PDT) In-Reply-To: <87wp7oaj3l.fsf@calancha-pc> (Tino Calancha's message of "Tue, 04 Jul 2017 14:04:14 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134182 Archived-At: Tino Calancha writes: > Alex writes: > >> That's more or less what I did at first, but I figured since cl-loop is >> a large macro, that it's best to quote the macro so that an accidental >> error doesn't halt testing. > I prefer just use (eval '...) in those cases where the expansion fails. > That way the file is more readable, and a reader focus her eye in those > failing expansions. I agree that it's more readable, and if I was doing this for my own project I'd just leave the (eval '...) out where possible. > Maybe we could add a comment in the file saying that those > `should-error' are failing expansions to be fixed. Part of the problem is that the "failing expansions that should be fixed" aren't wrapped in a should-error, but are wrapped in a should. The test itself is marked as ":expected-result :failed". >> It would be nice if the ert tests in general could just continue on with >> testing even if there are macro-expansion errors. > Sure, as long as the errors are expected. I think any macro-expansion errors inside of a should-error/should/should-not should be similarly to run-time errors. I also have a patch that appears to do this, but it breaks a few tests due to Bug#24402[1]. Perhaps a fix to that bug will also make it so that macro-expansion errors will be caught be should*. I hope that Bug#24402 can be fixed before committing these tests, so we can just remove the (eval '...) noise altogether. Footnotes: [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24402