From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Date: Thu, 10 Aug 2017 20:45:16 -0400 Message-ID: <87bmnn2aqr.fsf@users.sourceforge.net> References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1502412259 19878 195.159.176.226 (11 Aug 2017 00:44:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 11 Aug 2017 00:44:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: IRIE Shinsuke , 5615@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 11 02:44:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfy3f-0004cz-H0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 02:44:11 +0200 Original-Received: from localhost ([::1]:37890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfy3l-0001kx-O6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Aug 2017 20:44:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfy3b-0001iw-UE for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 20:44:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfy3X-0005zt-0S for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 20:44:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfy3W-0005ze-Qg for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 20:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dfy3W-0002Mv-Gd for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 20:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.15024122409091 (code B ref 5615); Fri, 11 Aug 2017 00:44:02 +0000 Original-Received: (at 5615) by debbugs.gnu.org; 11 Aug 2017 00:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:54892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfy3Q-0002MO-QR for submit@debbugs.gnu.org; Thu, 10 Aug 2017 20:44:00 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:37901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfy3F-0002Lw-Ts; Thu, 10 Aug 2017 20:43:51 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id m34so20777823iti.1; Thu, 10 Aug 2017 17:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/HM9+0GSdbBD1hPLzRokP4MCPgTlf7HHccOHnOxIUJA=; b=CVYOEAEzmE5wplRPwCxE2CHY496Dg/T6dWV94RUuVTrVh4JpbToqY8kDnI7hmKXBh0 NhmkphtrJujMjPeMgW7xWz5+WZyZzXMGthBH79oN6XlKbjoNmBNe93aNkX18uaR1h0tg ubLvaudS3Al/xUhABUzmZ8oSXv4GscgbCV5yv5QvhQryn77TNZsiPKSzbK+zAVgWSGLW BaSJgOaB3JepvYhcSJMhIZjs8lgBeHAb270EduZQFHRVoPOKbOLzIuWcD4DZ+wPfrAx8 oxiQsaAP3GHsoUcNZkLepS+pgUnAiDSeUXKTIrdz+ylpSchup4jkzAMLmyVJWgNdHOpz RM0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/HM9+0GSdbBD1hPLzRokP4MCPgTlf7HHccOHnOxIUJA=; b=I6W9NqrmjtpnjVJNLyRwdzcVgR7dVcJaNqlKh5k6nSAjrxBbxezvjFDxH4BKpStYTT 7u1zytr2fLRb3EvDa4fUPgDth8EGtxqCORcALmnWwmWOf0pM4z6k3MvshRyIxS4ohvYr +SfklUIGMophrvbI8QK1S4jHKdc8vUmQaCG0MQ3yMrxLhzuTf1pAKE/RGf3JgNnRWesY LbwJJ4Gk094PgknlLwBDaUJonP5XxM4mOAY5muF7dVJMlLbbP7x0ZnuvVnnZWMOverK4 JQcSz9HHRA8rViPWF6i69e3xKUfugl3fe9g5VaA3S9cmeXo80X95+UKPrLTFtpl8EprI tvtg== X-Gm-Message-State: AIVw113KoUdjmDC55pB6ikQ5T6a/t7sWknZ53MOzwsFn5yftGmihjJow tfBZ9uzWTX9vLzY5 X-Received: by 10.36.243.13 with SMTP id t13mr5674207ith.68.1502412220170; Thu, 10 Aug 2017 17:43:40 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id 80sm3824389itk.11.2017.08.10.17.43.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Aug 2017 17:43:38 -0700 (PDT) In-Reply-To: <87oab1tlku.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2016 17:06:57 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135634 Archived-At: --=-=-= Content-Type: text/plain tags 5615 + patch quit Lars Ingebrigtsen writes: > IRIE Shinsuke writes: > >> Sorry, the patch I sent with previous mail is bad, because the previous >> patch was made without considering `line-spacing' specified by a >> floating point number or frame-parameter. >> >> So I wrote the new patch. Please check it. > > [...] > > Is this still a problem in the current Emacs? Current Emacs still uses the same (1- (window-height)) expression, but I can't understand from the description when exactly this gives the wrong result. Furthermore, I don't see any justification which would explain why the new proposed significantly more complicated computation is more correct. I think we should just use window-text-height. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-lisp-term.el-term-mode-Use-window-text-height-Bug.patch Content-Description: patch >From b22407f5fedea77f34ca1efb5469e368164f9084 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 10 Aug 2017 20:43:13 -0400 Subject: [PATCH v2] * lisp/term.el (term-mode): Use `window-text-height' (Bug#5615). --- lisp/term.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/term.el b/lisp/term.el index 5eb7b3e8ed..12a37cafbe 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -1007,7 +1007,7 @@ term-mode (setq indent-tabs-mode nil) (setq buffer-display-table term-display-table) (set (make-local-variable 'term-home-marker) (copy-marker 0)) - (set (make-local-variable 'term-height) (1- (window-height))) + (set (make-local-variable 'term-height) (window-text-height)) (set (make-local-variable 'term-width) (window-max-chars-per-line)) (set (make-local-variable 'term-last-input-start) (make-marker)) (set (make-local-variable 'term-last-input-end) (make-marker)) -- 2.11.1 --=-=-=--