From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups Date: Wed, 13 Dec 2017 01:19:13 +0000 Message-ID: <87bmj3zapa.fsf@gmail.com> References: <87zi7ef3ab.fsf@gmail.com> <83indq3k79.fsf@gnu.org> <83h8t91obt.fsf@gnu.org> <87h8svzbeh.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1513128015 23003 195.159.176.226 (13 Dec 2017 01:20:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Dec 2017 01:20:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 29405@debbugs.gnu.org, yamaoka@jpl.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 13 02:20:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOviO-0005ST-Lg for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Dec 2017 02:20:04 +0100 Original-Received: from localhost ([::1]:33057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOviV-0004tc-Ou for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Dec 2017 20:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOviP-0004pj-N4 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:20:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOviM-0008LU-FT for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:20:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOviM-0008L7-B3 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOviM-0005OZ-26 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2017 01:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29405-submit@debbugs.gnu.org id=B29405.151312796220674 (code B ref 29405); Wed, 13 Dec 2017 01:20:02 +0000 Original-Received: (at 29405) by debbugs.gnu.org; 13 Dec 2017 01:19:22 +0000 Original-Received: from localhost ([127.0.0.1]:59130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOvhi-0005NO-2D for submit@debbugs.gnu.org; Tue, 12 Dec 2017 20:19:22 -0500 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:46213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOvhh-0005NA-0t for 29405@debbugs.gnu.org; Tue, 12 Dec 2017 20:19:21 -0500 Original-Received: by mail-wm0-f44.google.com with SMTP id r78so1973428wme.5 for <29405@debbugs.gnu.org>; Tue, 12 Dec 2017 17:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WelV1fFBVIlPges4dLtGN6CzHAUiMzElmRfz2TTyG8Y=; b=VqqZzDgZO8NgtBcqotGOmqmW5YYRaRBqNNkRfttVh1ZWIZHoDCIDRQVxWX15ARWBq5 yHwgtCMFfsFzIjWKp+QNOE9luXYfImwyPXVGENld2tHysBw1TCErnKKNsYAOelcbLDuN NjWSONrUL0OJ02uLqML3trw53x0G8r5lJhL+gAE12SWCyILPet4Xx4i0ErTGYOIUtiuY Im68KdBK6DzPDPtPATdboo/af/JAm/j1pVlB3NTn/nIiUAUWBlzxI/spBT2hn9CkGxW8 CDDK0z5KB2/QTVEdnbVZanpitYTQQ4uNgPGxQHzSI25pCQDpePGiw8UJgHNsOgv8/1ce m8qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WelV1fFBVIlPges4dLtGN6CzHAUiMzElmRfz2TTyG8Y=; b=cU03HzocB4tdV7j2La7OT6HQNWVH/LLRq2y+NaBvMo6o7S7f12oSSbB9h0fWJQJ2Gm RfdH4hgJiiAWRIOl+khlYoUp6JzRLqbh+xnN3S7os3RtzBAPwE5w5DHYVuN2A2HAWHFS lIcjQbtl/I9QLMg/kvqlBcJnOO15Lxcw8qlMlfNY/Nurn0WSkjYVHwfoD7KMwhMO1qj2 xWsD/cB4TFJlhDJyKzMS2FnlIeh+8uhhm6a4Tq0YuhMed8Ws2btNfRHklVv5Vmzl3O3y DTQlnsI8nfAsJB6xYV1S95tvu3tfZDDVRfmdSy3m20WCz2nm4OaJmvUlxRaP39IdNpT9 ErpQ== X-Gm-Message-State: AKGB3mJfrBxJl+6fUxhV9sgnYrsdYxJhwGu0ClJePeVesHiaIGLnKPFz wW/RS0/tnrGRV4XZzrsM9kXVgA== X-Google-Smtp-Source: ACJfBotAsUDZNKtekAZrMQGHmxzM7ZLvBK75y83UI7SIoI1GgD/brQeiXJhsGsN8a9QrOTmrSXBsKQ== X-Received: by 10.80.213.90 with SMTP id f26mr5411246edj.225.1513127955411; Tue, 12 Dec 2017 17:19:15 -0800 (PST) Original-Received: from localhost ([2a02:8084:4f41:8c80:9929:5bdb:4629:fab8]) by smtp.gmail.com with ESMTPSA id z5sm384576edh.76.2017.12.12.17.19.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 17:19:14 -0800 (PST) In-Reply-To: <87h8svzbeh.fsf@gmail.com> (Basil L. Contovounesios's message of "Wed, 13 Dec 2017 01:04:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141014 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Modernise-message.el-face-spec-syntax.patch >From 3f617f234a1a762b3f8eab42f9a339db3694ab59 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:10:20 +0000 Subject: [PATCH 2/2] Modernise message.el face spec syntax * lisp/gnus/message.el (message-header-to, message-header-cc) (message-header-subject, message-header-newsgroups) (message-header-other, message-header-name, message-header-xheader) (message-separator, message-cited-text, message-mml): Use (DISPLAY . PLIST) face spec syntax as recommended in `(elisp) Defining Faces'. --- lisp/gnus/message.el | 60 ++++++++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index c3aafd7c62..6053d33223 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1427,12 +1427,12 @@ message-mode-syntax-table (defface message-header-to '((((class color) (background dark)) - (:foreground "DarkOliveGreen1" :bold t)) + :foreground "DarkOliveGreen1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue" :bold t)) + :foreground "MidnightBlue" :bold t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying To headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-to-face @@ -1441,12 +1441,12 @@ 'message-header-to-face (defface message-header-cc '((((class color) (background dark)) - (:foreground "chartreuse1" :bold t)) + :foreground "chartreuse1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue")) + :foreground "MidnightBlue") (t - (:bold t))) + :bold t)) "Face used for displaying Cc headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-cc-face @@ -1455,12 +1455,12 @@ 'message-header-cc-face (defface message-header-subject '((((class color) (background dark)) - (:foreground "OliveDrab1")) + :foreground "OliveDrab1") (((class color) (background light)) - (:foreground "navy blue" :bold t)) + :foreground "navy blue" :bold t) (t - (:bold t))) + :bold t)) "Face used for displaying Subject headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-subject-face @@ -1469,12 +1469,12 @@ 'message-header-subject-face (defface message-header-newsgroups '((((class color) (background dark)) - (:foreground "yellow" :bold t :italic t)) + :foreground "yellow" :bold t :italic t) (((class color) (background light)) - (:foreground "blue4" :bold t :italic t)) + :foreground "blue4" :bold t :italic t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying Newsgroups headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-newsgroups-face @@ -1483,12 +1483,12 @@ 'message-header-newsgroups-face (defface message-header-other '((((class color) (background dark)) - (:foreground "VioletRed1")) + :foreground "VioletRed1") (((class color) (background light)) - (:foreground "steel blue")) + :foreground "steel blue") (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying other headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-other-face @@ -1497,12 +1497,12 @@ 'message-header-other-face (defface message-header-name '((((class color) (background dark)) - (:foreground "green")) + :foreground "green") (((class color) (background light)) - (:foreground "cornflower blue")) + :foreground "cornflower blue") (t - (:bold t))) + :bold t)) "Face used for displaying header names." :group 'message-faces) (define-obsolete-face-alias 'message-header-name-face @@ -1511,12 +1511,12 @@ 'message-header-name-face (defface message-header-xheader '((((class color) (background dark)) - (:foreground "DeepSkyBlue1")) + :foreground "DeepSkyBlue1") (((class color) (background light)) - (:foreground "blue")) + :foreground "blue") (t - (:bold t))) + :bold t)) "Face used for displaying X-Header headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-xheader-face @@ -1525,12 +1525,12 @@ 'message-header-xheader-face (defface message-separator '((((class color) (background dark)) - (:foreground "LightSkyBlue1")) + :foreground "LightSkyBlue1") (((class color) (background light)) - (:foreground "brown")) + :foreground "brown") (t - (:bold t))) + :bold t)) "Face used for displaying the separator." :group 'message-faces) (define-obsolete-face-alias 'message-separator-face @@ -1539,12 +1539,12 @@ 'message-separator-face (defface message-cited-text '((((class color) (background dark)) - (:foreground "LightPink1")) + :foreground "LightPink1") (((class color) (background light)) - (:foreground "red")) + :foreground "red") (t - (:bold t))) + :bold t)) "Face used for displaying cited text names." :group 'message-faces) (define-obsolete-face-alias 'message-cited-text-face @@ -1553,12 +1553,12 @@ 'message-cited-text-face (defface message-mml '((((class color) (background dark)) - (:foreground "MediumSpringGreen")) + :foreground "MediumSpringGreen") (((class color) (background light)) - (:foreground "ForestGreen")) + :foreground "ForestGreen") (t - (:bold t))) + :bold t)) "Face used for displaying MML." :group 'message-faces) (define-obsolete-face-alias 'message-mml-face -- 2.15.1 --=-=-= Content-Type: text/plain Sorry, I managed to omit the majority of face names from the patch which updates the face spec syntax, thanks to a combination of rushing and text collapsing. Kindly find attached a revised version. -- Basil --=-=-=--