From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21559: PATCH review needed: lisp/vc/vc-git.el (vc-git-state, vc-git-conflicted-files) Date: Mon, 19 Feb 2018 13:39:27 +0100 Message-ID: <87bmglkvb4.fsf@gmx.de> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519043903 8447 195.159.176.226 (19 Feb 2018 12:38:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Feb 2018 12:38:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: 21559@debbugs.gnu.org, Dmitry Gutov To: Alexei Khlebnikov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 19 13:38:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enkhv-0001NN-4j for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Feb 2018 13:38:11 +0100 Original-Received: from localhost ([::1]:49837 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enkjv-0006e0-Mm for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Feb 2018 07:40:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enkjn-0006de-Gl for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 07:40:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enkji-0002ok-KF for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 07:40:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enkji-0002oY-Ge for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 07:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1enkji-0006LN-9B for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 07:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2018 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.151904397924346 (code B ref 21559); Mon, 19 Feb 2018 12:40:02 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 19 Feb 2018 12:39:39 +0000 Original-Received: from localhost ([127.0.0.1]:50647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enkjJ-0006Ka-KS for submit@debbugs.gnu.org; Mon, 19 Feb 2018 07:39:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:50665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enkjH-0006KI-1W for 21559@debbugs.gnu.org; Mon, 19 Feb 2018 07:39:36 -0500 Original-Received: from detlef.gmx.de ([212.91.243.206]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LeMij-1eQqWT12Nh-00qF4j; Mon, 19 Feb 2018 13:39:28 +0100 In-Reply-To: (Alexei Khlebnikov's message of "Mon, 19 Feb 2018 11:24:57 +0100") X-Provags-ID: V03:K0:FJPhNwtJA4T+6BGqPjalcR+rEJ/cFusW+Mzk8igR4a9iT5dOAzp Kvp4rSOinvd6JGychv0R6y+v8++AD8JCPDZfnRHvbjG4nBHI8BXYLSVkdAkI93LHLrKDVOA WclgkeBjYiPNmmt2WOsjmF27x4UqLIahklNDpVVbLOw8TQd/AnauOaz3EL/Y2BLjyAnbi9K bi6aH6q4U9Uloy1k2DdIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:gEkWDW2vrCg=:uhvevO4gI9kft4+XU7mPcE kA76ysgGVGKpWhmRYnQiG8hIQR8xqTykMcEcO61H5VPY0V1mgfMpINtgvrXRm48Z7Eic4ajFn IBnx27pxQ0d7x1Eh7wRtivNLsYl16ROcGOCU/gpRYqYDuM7W4mOT74Lqe7LHwCgpGRwT6u4SW HWbvvPUHzxf/DT6M8SUk1aJDai56g9sAX3xARD2Pnc7t1KD2drJZCWTueGgbH5Rj1XK7d9TGh 9sYGsSzrOfSF8Z/PHBJsdavKQ+aOo4hEnD4jcODX3VEimxF0fDfJZplGKa3CbZpXQgHHc8ZFJ UCsTx85JrBjjO5w3i/O4XNJK0O294UHXRw0t5S9Gs8ijnSJT+zjxovSfNKPiuW1ZUfiAQvciY EVWLU5wa4HWO+zx727/yqnLu+PXGfICKFpxFAXr3tDpj67mDKZwoUszPbj05Ls2YtcnzNFvyf Ydpl5ixblHSBjV7rZXwW6FzU/OIYMeUOb1UlPv+6Wzy18/WlX73qxm1JsltENlEAT2PNh91Bv jtw9bwhi0BIQW7Nyi19Q4pYR6XU96XviqWhtyDM7vjfzL7LTQwYfTQ2rNWQLYHvjt0Vo4tfr8 MscIrybF65Z7g3sFG5edMKyakq2ItV39J9JOD9lWaHTf6XE/U4Xvby4fngcojepb/LlLYuoaV eDP/YbtEZm6V8FKy9OaTcGxKEn64mADPzobrXIJ7J7WY1ft9QwrwtJj/pNi4Y4YZmGlFH6lJP hUuBw/dLmtTa43AQ7XfL8QLKqz5JOpF1CKQhUynXOdARt8d4phn6m/1ZewETTAEnjp7hiMJG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143450 Archived-At: Alexei Khlebnikov writes: > Hi All, Hi Alexei, > https://debbugs.gnu.org/cgi/bugreport.cgi?msg=83;bug=21559;att=2;filename=0001-Fix-for-25.0.50-auto-revert-mode-breaks-git-rebase-B.patch I don't know git in detail, so I don't know whether this argument is useful. However, I don't believe this argument shall be added, depending on git version number. A better approach would be to prepend "GIT_OPTIONAL_LOCKS=0" in `process-environment'. This would work for any git version, w/o further check. For git version <= 2.15.0, it would simply do nothing. Best regards, Michael.