From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error Date: Thu, 22 Mar 2018 20:52:01 -0400 Message-ID: <87bmffsjf2.fsf@gmail.com> References: <87o9jg568u.fsf@violet.siamics.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521766269 10891 195.159.176.226 (23 Mar 2018 00:51:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 00:51:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30908@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 01:51:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezAvA-0002jH-Nu for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 01:51:04 +0100 Original-Received: from localhost ([::1]:35479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezAxD-0006Av-VD for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 20:53:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezAx7-00068i-PK for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 20:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezAx4-00017T-NJ for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 20:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezAx4-00017H-Ie for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 20:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezAx4-0006c0-8j for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 20:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30908 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30908-submit@debbugs.gnu.org id=B30908.152176633225356 (code B ref 30908); Fri, 23 Mar 2018 00:53:02 +0000 Original-Received: (at 30908) by debbugs.gnu.org; 23 Mar 2018 00:52:12 +0000 Original-Received: from localhost ([127.0.0.1]:48280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezAwF-0006at-HO for submit@debbugs.gnu.org; Thu, 22 Mar 2018 20:52:12 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:35254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezAwD-0006ag-34 for 30908@debbugs.gnu.org; Thu, 22 Mar 2018 20:52:09 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id v194-v6so606977itb.0 for <30908@debbugs.gnu.org>; Thu, 22 Mar 2018 17:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XmZm0pZ8rBj1XGxqkJa59zB1y74htWIjABOHwONRSZI=; b=m9l851n9yh5hKqjioPO/N9W+7TDI88pi/2HCVVjjf4OvsUNPZFR8+IdzOyDR4uerzx 4uZ72QFQ/eKTc3cDFbEXec5+j8S0DZLD+7AUAff34zHeMesqRv09whEXIg0BGVgQ7IAy eqoD+FFV8/y87pEQYQ3aXrXkg9Llx/2+DmW9dwWmKGy9cLW0aL0DdYCmR4ebPtIPcmP7 bqUgmvcYzeHSdzxwRgmKvUpboAXf/JRxxoh4JQ+B0R0dmYwya1YyVdfLHrMvXI2YeZz/ 0/N28iQu1wW5wCxse7CiosA45TVRBwuprECYuVsMoAQcqnzr4E7gf13yIUYC7s6MMlRW zVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XmZm0pZ8rBj1XGxqkJa59zB1y74htWIjABOHwONRSZI=; b=GQHzrK94Oz5p8zCtA9Zwin1gYVtIT/FF48Y+yt0JZlDHzNNtrmmhV0gnK9No3Lg2oC wLYW0LZkYBDzDqCjbrov6fPFwOSg2BE1VKD4pOWHlE7a81Ol0dbKuanlgg4Fq19mgIo7 Tbz7XZL/0CTbhIhr10tbf/UMs1zDd+tHXvMa3H0uX5C+0nbeFX2slUaxswaCW8vByNjO UKH9Kj7TORicTVDpNz8D7sIj23qb80ncb3ZdXSMpUxaqkOgPNkrPgFHxp1xsaeg2OmDn yiriO0eS6UsHQ6Z/f2YYiiCb/Q9ipGZ8fFfySQ3qviDahQ5pGUWH3gavGIO0nEpXGR08 Lvig== X-Gm-Message-State: AElRT7GWvoT2cUMMgePTT0onT4IWPz99+/Asfik5Gl5UYlabzU7Se0Gm SkICghbE+KwnviW5FHkoX95C7w== X-Google-Smtp-Source: AG47ELu55rjHXryivn9hghnU/19QE+iRAhu7BiKVgzuqqAiZNKKjznTnQ02S+J3xhgzJ0URqHDe/yQ== X-Received: by 2002:a24:5d41:: with SMTP id w62-v6mr11619610ita.15.1521766323324; Thu, 22 Mar 2018 17:52:03 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q21-v6sm4985134itb.2.2018.03.22.17.52.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 17:52:02 -0700 (PDT) In-Reply-To: <87o9jg568u.fsf@violet.siamics.net> (Ivan Shmakov's message of "Thu, 22 Mar 2018 18:12:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144542 Archived-At: Ivan Shmakov writes: > --- woman.el.~1~ 2017-11-05 15:00:52.696647297 +0000 > +++ woman.el 2018-03-22 17:47:44.014986089 +0000 > @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer () > + (unwind-protect > + (if (not (eobp)) ; This should not happen, but ... > + (woman2-format-paragraphs (copy-marker (point-max) t) > + woman-left-margin)) > + (fset 'canonically-space-region canonically-space-region) > + (fset 'set-text-properties set-text-properties) > + (fset 'insert-and-inherit insert-and-inherit) > + (set-marker to nil))))) Shouldn't this rather be combined into the existing unwind-protect around the while?