From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Colin Baxter Newsgroups: gmane.emacs.bugs Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Date: Sat, 31 Mar 2018 19:56:30 +0100 Message-ID: <87bmf4f50h.fsf@yandex.com> References: <83po3qga5g.fsf@gnu.org> <838tabdu3x.fsf@gnu.org> <83y3ibcbms.fsf@gnu.org> <83zi2o6u5g.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522522513 5113 195.159.176.226 (31 Mar 2018 18:55:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Mar 2018 18:55:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: , 30955@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 31 20:55:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Lee-0001CM-5F for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2018 20:55:08 +0200 Original-Received: from localhost ([::1]:45775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2Lgh-0001bt-Lq for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2018 14:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2LgX-0001bQ-US for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 14:57:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2LgU-0004HG-Nz for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 14:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2LgU-0004Gk-Jc for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 14:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f2LgU-0000nW-5d for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Colin Baxter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Mar 2018 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30955-submit@debbugs.gnu.org id=B30955.15225226033042 (code B ref 30955); Sat, 31 Mar 2018 18:57:02 +0000 Original-Received: (at 30955) by debbugs.gnu.org; 31 Mar 2018 18:56:43 +0000 Original-Received: from localhost ([127.0.0.1]:33261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2LgA-0000my-B7 for submit@debbugs.gnu.org; Sat, 31 Mar 2018 14:56:43 -0400 Original-Received: from forward106o.mail.yandex.net ([37.140.190.187]:43304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Lg8-0000ml-4x for 30955@debbugs.gnu.org; Sat, 31 Mar 2018 14:56:41 -0400 Original-Received: from mxback4j.mail.yandex.net (mxback4j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10d]) by forward106o.mail.yandex.net (Yandex) with ESMTP id 6ABFF784193; Sat, 31 Mar 2018 21:56:33 +0300 (MSK) Original-Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback4j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id YmRmVNhe8M-uW9CBT5m; Sat, 31 Mar 2018 21:56:33 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1522522593; bh=ZggtLsJFuUMeHLfun+6p1zYPIvZLH8lcSpeDoCJQP3I=; h=From:To:Cc:Cc:Subject:References:Date:In-Reply-To:Message-ID; b=ZqopPD68XGK0mYYpWl+Qa0FIu6KASPiHZaEMAPjOu2zOVSblXm5k/ukd/mGBfGKxK ByDpwDbimtub7YK1uwtAOD9gYs+qu1L1VRBbq9AWPPpQBuO7ovLN1dYdudxaJv3j7u vBM3FcvmalGucjv5X2/Z9PxD00suUalKFzjJ61oc= Original-Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id vW4H2LUxDh-uVISMUb1; Sat, 31 Mar 2018 21:56:31 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1522522591; bh=ZggtLsJFuUMeHLfun+6p1zYPIvZLH8lcSpeDoCJQP3I=; h=From:To:Cc:Cc:Subject:References:Date:In-Reply-To:Message-ID; b=A1u4rSUoWL0RoI2Q9oT0QL9Si4+Opk67IsdoOVtNV74JwsUPK7zpqtG5wt6xmgvKp +glnz1L6Ysv8NXl6eoyfQhCfA+rIGc20l9MizSzbEtKz4TrPAONcOePKE/J+wKvGhM zrKUrvBD+yBMR/iKS7qtcFPfCMUSTLLP5fRM09Hg= Authentication-Results: smtp3p.mail.yandex.net; dkim=pass header.i=@yandex.com X-Face: -P+89ASh_wrs;AUGm`!l[}/o-lyK}5W.gq\fkJ{#d6Gu,hWrZNz::iMm5PJb} __A96]-LUrl)X=uF=V|\3-\9/sXvBs/H In-Reply-To: <83zi2o6u5g.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Mar 2018 20:18:19 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAACwAAAAMCAIAAACWSshgAAAABmJLR0QA/wD/AP+gvaeTAAAA hklEQVQ4je2UwQ3CQAwEh8gR3IGolQ5TAr3w4mIT8wAa8PLM/nc1stc+LAvTRFmPO9db3Q5sYL1j Vo+IIxeJgQBrjXmuR4wTXYNwEDbxP5k7mXW/B6tGEGARWkSgBRBgmdIkMhHcAPm5DqWYa+OsQezF /OlbTAnCcQ3iBTaG9LZH8NQgNngDnag2wOvtnJ4AAAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144768 Archived-At: >>>>> Eli Zaretskii writes: >> From: Stefan Monnier Cc: >> 30955@debbugs.gnu.org, m43cap@yandex.com Date: Thu, 29 Mar 2018 >> 09:11:41 -0400 >> >> >> There's indeed a bug, here, which is that it says >> >> >> >> (translated from ) >> >> >> >> instead of >> >> >> >> (translated from ) >> >> >> >> I assume it's because the fix I installed modifies the event >> in-place, >> so the recording of "untranslated events" gets >> changed by side-effect. >> > >> > I don't think so: I saw the mouse-2 part even before you fixed >> the > problem. >> >> Maybe you've seen it with yet-older code, such as the one in the >> emacs-26 branch (in that code, the mouse-1 => mouse-2 remapping >> was done elsewhere (i.e. as part of the processing of >> down-mouse-1) so read_key_sequence never even saw the mouse-1 >> event to put it into the raw_keybuf)? >> >> > So I think it's something else at work. >> >> Yet the second hunk below does fix this problem (the first hunk >> fixes the same problem but for C-h l, and the third just removes >> code which does something wrong, and I have no idea why the code >> was there in the first place). > AFAICT, this patch is now installed on master, but I still see the > same issue: "C-h c" reports mouse-2 whereas I click mouse-1. Was > this issue supposed to be resolved, and if so, what am I missing? For me, C-h c gives mouse-1 for the left-hand button (mouse 1) and mouse-3 for the right-hand button (mouse 3). Best wishes, Colin.