From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Date: Sun, 06 May 2018 12:28:16 -0400 Message-ID: <87bmdsn3z3.fsf@gmail.com> References: <87sh747vsf.fsf@tcd.ie> <87efiona6i.fsf@gmail.com> <87muxcomoy.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1525624032 25368 195.159.176.226 (6 May 2018 16:27:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 May 2018 16:27:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: 31373@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 06 18:27:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFMV7-0006Ty-TD for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 18:27:06 +0200 Original-Received: from localhost ([::1]:42695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFMXE-00014m-Rn for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 12:29:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFMX5-00013Q-Ne for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 12:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFMX0-0004IF-Pm for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 12:29:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFMX0-0004I4-JD for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 12:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFMX0-0006VC-84 for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 May 2018 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31373-submit@debbugs.gnu.org id=B31373.152562410524942 (code B ref 31373); Sun, 06 May 2018 16:29:02 +0000 Original-Received: (at 31373) by debbugs.gnu.org; 6 May 2018 16:28:25 +0000 Original-Received: from localhost ([127.0.0.1]:51575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFMWO-0006UD-Pb for submit@debbugs.gnu.org; Sun, 06 May 2018 12:28:24 -0400 Original-Received: from mail-io0-f175.google.com ([209.85.223.175]:39139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFMWN-0006U1-VP for 31373@debbugs.gnu.org; Sun, 06 May 2018 12:28:24 -0400 Original-Received: by mail-io0-f175.google.com with SMTP id r9-v6so30935778iod.6 for <31373@debbugs.gnu.org>; Sun, 06 May 2018 09:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=+SkNwAFp7YjGMtXCsfpQy/HkM7wE/Ub/gw1b66qg8OY=; b=XQZaRLG7e7/8RJR1TRKLbhi/Qv7rcVVLeEvTtmPLsMpSWpsTAelmKgFpnicJMLSFrS HR56KSJ1qm+hwBRiIs7+MvWb5ZzN9msH959SLKYzwX4MGcVTXDQtWTDfC/KGFh+++on0 KHOr1ZyVgEcxbgKdMihOnzCsX3loOmcRrNEsLoqJqFL11R5UHRS2F0MLJiCGTSAszu7h od8rGZafoWWLQugD67hN1KPT/KzovVqCy4tmE5/RloMzr8u+y48AZORoNFeOSQ59w42p qd8nLDDhXsKab6OrNcUWzgOSTEGhJGRDzpYxBMDIMAF4tYV1RDMFCCeXSbxdUwSaulvu N11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+SkNwAFp7YjGMtXCsfpQy/HkM7wE/Ub/gw1b66qg8OY=; b=qTtImyqtzL98SQpPUqJ4bh1QS4PjSVZlcMAaCrEmhVm7T6fYpzOYNf8bedS0+pQ49j c6vEFdxz6OxwNtPnOqIiVeta3KU8+O/iFeWYm2OTm4X0Y2KJLaTwCfa66KsbjYoJEkmv bNodur+T2RuomVExCqSulX0szLLNC8WVa27koTwJbfNKN58xole72aVpqjjfOZHDeiMQ eTzscfCDuo2ELYlTKMtV3TQCmPi6Cn3xQt3j6ph11Vt/HaEQd77L9E1u6Nrb+nUYTzWf QjYQV4Qupq9fGshXEJW2oheUIk51K6LGV7WLin5hFYT8mUck7oo0V0wCY5Xxn6zkPv+X dNOQ== X-Gm-Message-State: ALQs6tB2LK5umnYe3Uzz+MLIbSE/yoAOmaIbWggV1P1D8+IQgr+/WjKw Tn5jk2b65zWz4SqVhueKwW6VZA== X-Google-Smtp-Source: AB8JxZoyCgkFvQb4CpDEUPC1lZ+mOv3DEVHaMZzv2xZ/ho12WTB3Ldd8cvr+byW8o3qVe7ZKwFb3mQ== X-Received: by 2002:a6b:da04:: with SMTP id x4-v6mr37027575iob.19.1525624098076; Sun, 06 May 2018 09:28:18 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n201-v6sm3315685itn.7.2018.05.06.09.28.17 for <31373@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 May 2018 09:28:17 -0700 (PDT) In-Reply-To: <87muxcomoy.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 06 May 2018 15:58:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146047 Archived-At: --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Ah, yes, thank you. I forgot about --fg-daemon (which I now remembered > is documented in '(emacs) Initial Options') because it is not mentioned > in the emacs(1) man page; do you think this option should be added there? Oh, yes it should be. >> + if (XFRAME (frame)->output_method == output_x_window Also, I noticed that there is FRAME_X_P for this. I can't find any more obvious instances of missing this check, although it's hard to tell in many cases if the frame is really guaranteed to have output_x_window has the output_method. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Don-t-check-non-X-frames-for-z-order-Bug-31373.patch Content-Description: patch >From 5ad7571a59eb744c65a23198729ea2b56155a2c2 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 6 May 2018 10:07:25 -0400 Subject: [PATCH v2] Don't check non-X frames for z order (Bug#31373) * src/xfns.c (x_frame_list_z_order): Only use frames with `output_method' set to `output_x_window'. --- src/xfns.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xfns.c b/src/xfns.c index 20fe61bffd..863fdefa5f 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -5303,8 +5303,9 @@ x_frame_list_z_order (Display* dpy, Window window) /* With a reparenting window manager the parent_desc field usually specifies the topmost windows of our frames. Otherwise FRAME_OUTER_WINDOW should do. */ - if (XFRAME (frame)->output_data.x->parent_desc == children[i] - || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i]) + if (FRAME_X_P (frame) + && (XFRAME (frame)->output_data.x->parent_desc == children[i] + || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i])) frames = Fcons (frame, frames); } -- 2.11.0 --=-=-=--