From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31498: [PATCH] Notify systemd in daemon-initialized Date: Thu, 07 Jun 2018 09:08:51 -0400 Message-ID: <87bmcm3frw.fsf@gmail.com> References: <20180518174031.12514-1-mail@lucaswerkmeister.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528376895 1305 195.159.176.226 (7 Jun 2018 13:08:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Jun 2018 13:08:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31498@debbugs.gnu.org To: Lucas Werkmeister Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 07 15:08:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQue7-0000CJ-HB for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 15:08:07 +0200 Original-Received: from localhost ([::1]:57876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQugE-0000Qb-LJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 09:10:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQug5-0000QJ-6l for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 09:10:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQufz-0004lY-8y for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 09:10:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQufz-0004lO-4a for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 09:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fQufy-0002AF-NP for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 09:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jun 2018 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31498-submit@debbugs.gnu.org id=B31498.15283769438246 (code B ref 31498); Thu, 07 Jun 2018 13:10:02 +0000 Original-Received: (at 31498) by debbugs.gnu.org; 7 Jun 2018 13:09:03 +0000 Original-Received: from localhost ([127.0.0.1]:37551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQuf0-00028s-Vv for submit@debbugs.gnu.org; Thu, 07 Jun 2018 09:09:03 -0400 Original-Received: from mail-it0-f68.google.com ([209.85.214.68]:54093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQuez-00028I-44; Thu, 07 Jun 2018 09:09:01 -0400 Original-Received: by mail-it0-f68.google.com with SMTP id a195-v6so12730856itd.3; Thu, 07 Jun 2018 06:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XcUqqe0gRfqcWdqcf0J9sIIEMhELgy23N/ghRuwy8fE=; b=cxBTd+C6kQm3OhrzoiA7tEc3eyYCRe9FjqiBDLbHHkzS6PqYBWZ4Lo21ERHxJQ0h89 h0P8FZLG5bE+/ohA8RCmAklbBt3di3TeW67aSXo7X3lLX16qdR0UalFnN01hCUBfhtR3 hMlPs2H4LODNrcH9m8du668PWb8wh4+8j9qoiloyOLC2xPtEQKx20hsIt+HO8TuZaJVz HL69teePG7N3KiSuJ4XD19soIjgyMBVeiOecWKBUFdxNDIsXGoMHQvRSSnBW/haJT8D3 8tkSWLgAe2t2bdzDUdFX3Nd21EdnDh8r18jgo6sbYWaXkXC6tx8wdGRPFws9lr9KeTym GWUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XcUqqe0gRfqcWdqcf0J9sIIEMhELgy23N/ghRuwy8fE=; b=ZRwvMKNVReYXJX3L7hP4qPJKhz6c9V0p74dlbcFY/iKBq4LpNC12TjqvRlHWDgayh5 +Y3NZcPUsT4NlMhC93cOgwppTMfxDVCuWBXBlZyF9EclKqSzd3d0M0jlQqbC2iruQUfw GtYSW2bIM9AfyyoH7SA8PbrXaw6B9oc1kemm8vY7sRaLR8HkCWf68vCEZmp5rB3LnlKz 54rkflztuvTMjbTTnGAgxzFiFSXKSSdVR9gOr8giwb4downKxpYcGMp+HnEoPZ3X/4Ap VWTvKwBz6+2pMSTfzwkqv3b2TQBHpzHqQ9H6k8ZV4IsGC/09YcYhxo1Sj/ovZ8yuroGf LOPg== X-Gm-Message-State: APt69E396W4n4HKl/T+Ku5QsaKZvtC3WXqJbXM71r91Ohp2g1sa+VVD1 sCBFwboYOhtClwtNjAvxVyKMAA== X-Google-Smtp-Source: ADUXVKIjBeZgsvKsvIqWexe7haBRMVeCxbcxirUV6K+wZaqblqpuASRax8SOeXgffh+2DOxS/3AtoQ== X-Received: by 2002:a24:d651:: with SMTP id o78-v6mr1727963itg.94.1528376935530; Thu, 07 Jun 2018 06:08:55 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z6-v6sm4818648iob.15.2018.06.07.06.08.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 06:08:54 -0700 (PDT) In-Reply-To: <20180518174031.12514-1-mail@lucaswerkmeister.de> (Lucas Werkmeister's message of "Fri, 18 May 2018 19:40:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147133 Archived-At: severity 31498 wishlist severity 31521 wishlist quit Thanks, the patch seems straightforward enough. Just a few minor comments about formatting. Have you assigned copyright for Emacs? The patch is small enough to go in anyway, it would just have to be marked. Lucas Werkmeister writes: > With --[bg-]daemon and Type=forking, systemd will only consider the > daemon to have fully started up once the original process exits, and > will wait until then to start units depending on the Emacs service. To ^ double space > get the same functionality with --fg-daemon, use Type=notify instead of > Type=simple and explicitly send a readiness notification to systemd at > the point where the forked process would in --bg-daemon mode notify its > parent process and cause it to exit. > * etc/emacs.service: update Type The ChangeLog entries should be captilalized and end with a period: "Update Type." > * src/emacs.c (daemon-initialized): call sd_notify() Same here. I think it should have a NEWS entry mentioning that Emacs now supports this systemd notification feature. I would probably go ahead and combine with #31521, since it's using the same feature.