From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernt Hansen <bernt@norang.ca>
Subject: Re: Bug: org-toggle-tag always marks buffer modified [9.1.13
 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]
Date: Tue, 19 Jun 2018 10:32:50 -0400
Message-ID: <87bmc6q225.fsf@norang.ca>
References: <CADbSrJz+3KsCeZ32aN8mytWwLjmui-KBSSjFNf-v8rgDU90oEw@mail.gmail.com>
	<877emvi5o5.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bernt@norang.ca>) id 1fVHgt-0005X9-81
	for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 10:33:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bernt@norang.ca>) id 1fVHgp-0004HT-AS
	for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 10:33:03 -0400
Received: from outbound1a.eu.mailhop.org ([52.58.109.202]:45587)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bernt@norang.ca>) id 1fVHgp-0004Eu-2y
	for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 10:32:59 -0400
In-Reply-To: <877emvi5o5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Tue, 19 Jun 2018 09:42:02 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>, Allen Li <darkfeline@felesatra.moe>

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Allen Li <darkfeline@felesatra.moe> writes:
>
>> org-toggle-tag always marks the buffer as modified due to how it is
>> implemented.  It would be better if it did not mark the buffer
>> modified if it does not change anything.  This is annoying for
>> org-depend.el (which is contrib, not officially supported) because the
>> org-blocker-hook set by org-depend.el will mark the buffer modified
>> whenever an agenda view is built/refreshed.
>
> Fixed. Thank you.

Hi Nicholas,

This fix breaks my capture templates.

commit 593058e4a6270f52fdede2b871a0ee6504944f13
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Tue Jun 19 09:40:00 2018 +0200

    `org-set-tags' modifies buffer only when necessary

    * lisp/org.el (org--align-tags-here):
    (org-set-tags): Modify buffer only when necessary.

    * testing/lisp/test-org.el (test-org/set-tags): Add tests.

    Reported-by: Allen Li <darkfeline@felesatra.moe>
    <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00242.html>



I have reverted it locally and it works again.

My normal TODO capture template doesn't allow SPC to separate words when
entering the new headline for the task.

The relevant capture template entry is

(setq org-capture-templates
      (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
             "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
...

After opening the capture window and point is moved to the %? position I
type the headline but SPC no longer enters a space.  C-v SPC works but
that is inconvenient.

Thanks,
Bernt