From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Nathan Neff <nathan.neff@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Agenda search: setting sort-order
Date: Tue, 19 Jun 2018 22:20:11 +0200 [thread overview]
Message-ID: <87bmc6edfo.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAC=HedC9PwZYPMuH73F02odgmVm91169B3CBes3x0G1rRsJB0A@mail.gmail.com> (Nathan Neff's message of "Mon, 18 Jun 2018 13:16:41 -0500")
Hello,
Nathan Neff <nathan.neff@gmail.com> writes:
> I had a look at org-agenda.el, and took a first stab at "coding" :)
> I fixed the sorting problem when using agenda-search-view, and
> I have a DIFF/patch at the bottom of this e-mail [1] that provided the fix.
>
> Would this be of interest to the org-mode project?
IMO, the Org mode project is interested in having its bugs fixed ;)
> This code fixes the
> problem,
> but it is duplicated in the function org-agenda-get-todos, and seems
> redundant,
> therefore a more "long term" fix would probably not resemble the minor patch
> below. Also, I have no experience with lisp, nor the org-mode
> codebase :-O
A more "long term" fix would be to rewrite the agenda (asynchronous,
more scalable, better API for external use).
> Here's steps I used to find the problem. Feel free to skip to [1]
> for the DIFF/patch.
Would you mind sending it using `git format-patch'?
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-06-19 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 21:57 Agenda search: setting sort-order Nathan Neff
2018-06-12 20:07 ` Nathan Neff
2018-06-18 18:16 ` Nathan Neff
2018-06-19 20:20 ` Nicolas Goaziou [this message]
2018-08-02 1:28 ` Nathan Neff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmc6edfo.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=nathan.neff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.