From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-devel@gnu.org
Subject: Tests involving post-command-hook
Date: Wed, 01 Aug 2018 00:10:27 +0200 [thread overview]
Message-ID: <87bmangip8.fsf@gmx.net> (raw)
I'm using ERT to test for the hl-line face property and it appears that
in the test environment, the function hl-line-highlight is not
automatically run from post-command-hook as it should be, although I use
call-interactively to mimic a command invocation. It works only if I
explicitly call run-hooks. I also see this without ERT:
(let ((buf (get-buffer-create "*hl-line-test*")))
(with-current-buffer buf
(erase-buffer)
(insert "This is a test.\n")
(hl-line-mode)
(call-interactively (lambda () (interactive) (forward-line -1)))
;; (run-hooks 'post-command-hook)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test1 passed")
(message "test1 failed"))
(hl-line-mode -1)
(erase-buffer)
(insert "This is a test.\n")
(call-interactively (lambda () (interactive) (forward-line -1)))
(hl-line-mode)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test2 passed")
(message "test2 failed"))
(hl-line-mode -1)
(erase-buffer)
(insert "This is line 1.\nThis is line 2.\n")
(call-interactively (lambda () (interactive) (forward-line -1)))
(hl-line-mode)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test3.1 passed")
(message "test3.1 failed"))
(call-interactively (lambda () (interactive) (forward-line -1)))
;; (run-hooks 'post-command-hook)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test3.2 passed")
(message "test3.2 failed")))
(hl-line-mode -1))
Evaluating this in emacs -Q or loading it with emacs --batch yields
this:
test1 failed
test2 passed
test3.1 passed
test3.2 failed
The two successful tests are because hl-line-mode calls
hl-line-highlight before adding it to post-command-hook. Uncommenting
the two (run-hooks 'post-command-hook) lines yields this, which is what
I expected without run-hooks (and what I see when testing without them
interactively):
test1 passed
test2 passed
test3.1 passed
test3.2 passed
Is this behavior of post-command-hook expected and if so, is using
run-hooks in ERT valid, i.e. is it still really testing hl-line-mode
behavior?
Steve Berman
next reply other threads:[~2018-07-31 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 22:10 Stephen Berman [this message]
2018-07-31 23:50 ` Tests involving post-command-hook Noam Postavsky
2018-08-01 8:47 ` Stephen Berman
2018-08-01 11:51 ` Stefan Monnier
2018-08-01 12:37 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmangip8.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.