all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Tests involving post-command-hook
Date: Wed, 01 Aug 2018 14:37:40 +0200	[thread overview]
Message-ID: <87bmamz2i3.fsf@gmx.net> (raw)
In-Reply-To: <jwv1sbimhrf.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Wed, 01 Aug 2018 07:51:06 -0400")

On Wed, 01 Aug 2018 07:51:06 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> I'm using ERT to test for the hl-line face property and it appears that
>> in the test environment, the function hl-line-highlight is not
>> automatically run from post-command-hook as it should be, although I use
>> call-interactively to mimic a command invocation.  It works only if I
>
> pre/post-command-hook is run by the command *loop*, not by call-interactively.
>
> The command loop is the chunk of C code which does something like:
>
>     (while t
>       (let ((keys (read-key-sequence)))
>         (run-hooks 'pre-command-hook)
>         (call-interactively (key-binding keys))
>         (run-hooks 'post-command-hook)
>         (redisplay)))
>
> We don't want call-interactively to run those hooks, because commands
> may internally call call-interactively themselves.

My misunderstanding, thanks for clarifying.  In any case, as Noam
Postavsky pointed out, I can get the job done with ert-simulate-command.

Steve Berman



      reply	other threads:[~2018-08-01 12:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 22:10 Tests involving post-command-hook Stephen Berman
2018-07-31 23:50 ` Noam Postavsky
2018-08-01  8:47   ` Stephen Berman
2018-08-01 11:51 ` Stefan Monnier
2018-08-01 12:37   ` Stephen Berman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmamz2i3.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.