From: Marcin Borkowski <mbork@mbork.pl>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: How about lifting the limit of 35 tasks in org-clock-history?
Date: Sat, 08 Sep 2018 17:28:36 +0200 [thread overview]
Message-ID: <87bm98m2jf.fsf@mbork.pl> (raw)
In-Reply-To: <87zhwuu2u7.fsf@nicolasgoaziou.fr>
On 2018-09-06, at 16:18, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> I decided to put a warning about this in the docstring in my patch. My
>> assumption was that this is enough. If a user wants to change the
>> default, he will most probably see the docstring and will have to
>> actively ignore the warning.
>
> I don't think this is enough. As you put it, it instills doubt without
> explaining anything. Why 35? Why "may not work"? What "may not work"?
OK. How about
1. making the docstring more precise
2. leaving the limit, but instead of hard-coded 35 make it configurable
using a variable?
>> I do not use the vanilla Org way of selecting tasks to clock from
>> history - I use org-mru-clock, for which the restriction doesn't make
>> sense. So we have something else to use,
>
> I meant "have something else to use out of the box". I.e., not with an
> external library.
I see.
Frankly, I think the out-of-the-box way of selecting tasks from history
is not very good. For starters, it won't work with completion (like
org-mru-clock does). Also, I think the window with the list in not
scrollable.
> I agree with the idea of removing this limitation, but I'm not convinced
> your patch is ideal yet.
Thanks. I'll submit a better one soon.
--
Marcin Borkowski
http://mbork.pl
next prev parent reply other threads:[~2018-09-08 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 5:56 How about lifting the limit of 35 tasks in org-clock-history? Marcin Borkowski
2018-09-02 12:45 ` Nicolas Goaziou
2018-09-02 14:50 ` Marcin Borkowski
2018-09-06 14:11 ` Marcin Borkowski
2018-09-06 14:18 ` Nicolas Goaziou
2018-09-08 15:28 ` Marcin Borkowski [this message]
2018-10-02 6:12 ` Marcin Borkowski
2018-10-03 10:51 ` Nicolas Goaziou
2018-10-03 12:19 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm98m2jf.fsf@mbork.pl \
--to=mbork@mbork.pl \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.