From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: Linking to ImageMagick by default Date: Wed, 05 Dec 2018 20:31:08 +0100 Message-ID: <87bm5zwz2b.fsf@chopper> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544038201 6934 195.159.176.226 (5 Dec 2018 19:30:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2018 19:30:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 05 20:29:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUcrs-0001cv-Qp for ged-emacs-devel@m.gmane.org; Wed, 05 Dec 2018 20:29:56 +0100 Original-Received: from localhost ([::1]:36396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUctz-0000yZ-5L for ged-emacs-devel@m.gmane.org; Wed, 05 Dec 2018 14:32:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUctF-0000yN-QC for emacs-devel@gnu.org; Wed, 05 Dec 2018 14:31:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUct9-0000Pu-6l for emacs-devel@gnu.org; Wed, 05 Dec 2018 14:31:21 -0500 Original-Received: from smtp.outgoing.loopia.se ([194.9.95.112]:45412) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gUct8-0000ND-0r for emacs-devel@gnu.org; Wed, 05 Dec 2018 14:31:14 -0500 Original-Received: from s554.loopia.se (localhost [127.0.0.1]) by s554.loopia.se (Postfix) with ESMTP id 30CAD1F17086 for ; Wed, 5 Dec 2018 20:31:10 +0100 (CET) Original-Received: from s498.loopia.se (unknown [172.21.200.96]) by s554.loopia.se (Postfix) with ESMTP id 129A479E5D7; Wed, 5 Dec 2018 20:31:10 +0100 (CET) Original-Received: from s549.loopia.se (unknown [172.21.200.105]) by s498.loopia.se (Postfix) with ESMTP id 0F5EC449452; Wed, 5 Dec 2018 20:31:10 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se Original-Received: from s630.loopia.se ([172.21.200.105]) by s549.loopia.se (s549.loopia.se [172.21.200.137]) (amavisd-new, port 10024) with LMTP id v10_6xQjKWrS; Wed, 5 Dec 2018 20:31:08 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: joakim.verona@chimeslab.se X-Loopia-Originating-IP: 81.170.223.63 Original-Received: from ubermaschine (h-223-63.A149.priv.bahnhof.se [81.170.223.63]) (Authenticated sender: joakim.verona@chimeslab.se) by s630.loopia.se (Postfix) with ESMTPSA id C1A35C66324; Wed, 5 Dec 2018 20:31:08 +0100 (CET) In-Reply-To: (Glenn Morris's message of "Wed, 05 Dec 2018 12:24:03 -0500") X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 194.9.95.112 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231647 Archived-At: Glenn Morris writes: > Lars Ingebrigtsen wrote: > >> Without image scaling, modes that display images become pretty >> worthless. > > I think that is an issue that will vary from person to person. > >> I think the long term solution here is to implement image scaling in >> Emacs (probably not very hard) and then drop ImageMagick-by-default >> after that's been done. > > Do you have an opinion of GraphicsMagick? > It claims to be more stable and secure than ImageMagick. > I guess that someone who knows the Emacs ImageMagick code could port it > to GraphicsMagick fairly easily. (I don't, and didn't, bug#14358). > Porting to GraphicsMagick ought to be fairly straightforward. Copy pasting a textbook image scaler into the emacs codebase ought also be straightforward. If this is done I would humbly suggest that the ImageMagic/GraphicsMagick code is kept around as an alternative. This is because Imagemagic has support for some less common file formats that I use. I can of course keep a patch around or make a module. As an aside I used the ImageMagick code in Emacs to preview about 130000 images that I scanned using Emacs. I remember it as being very stable. But I guess times change. -- Joakim Verona joakim@verona.se