From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Sun, 06 Jan 2019 01:17:33 +0200 Organization: LINKOV.NET Message-ID: <87bm4uae42.fsf@mail.linkov.net> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <04e35f79-fa02-b643-04c4-8d6a5587cce5@yandex.ru> <87wonlwa6o.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1546731022 10410 195.159.176.226 (5 Jan 2019 23:30:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Jan 2019 23:30:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33870@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 06 00:30:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from listsout.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfvOT-0002Y7-KJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jan 2019 00:30:17 +0100 Original-Received: from localhost ([127.0.0.1]:48805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfvQZ-0004IX-OQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 18:32:27 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:60786 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfvQQ-0004I8-84 for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 18:32:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfvQC-0003Or-Ja for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 18:32:11 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfvQB-0003N1-0Z for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 18:32:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfvQA-0005l7-L5 for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 18:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jan 2019 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154673111922128 (code B ref 33870); Sat, 05 Jan 2019 23:32:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 5 Jan 2019 23:31:59 +0000 Original-Received: from localhost ([127.0.0.1]:48125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfvQ7-0005kq-48 for submit@debbugs.gnu.org; Sat, 05 Jan 2019 18:31:59 -0500 Original-Received: from insect.birch.relay.mailchannels.net ([23.83.209.93]:53743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfvQ3-0005kg-VM for 33870@debbugs.gnu.org; Sat, 05 Jan 2019 18:31:57 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D9D0F282633; Sat, 5 Jan 2019 23:31:54 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9572628257D; Sat, 5 Jan 2019 23:31:54 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 05 Jan 2019 23:31:54 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Obese-Stop: 50e9f5f30be3a72f_1546731114765_32692906 X-MC-Loop-Signature: 1546731114765:3637912761 X-MC-Ingress-Time: 1546731114764 Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTP id 543427F5B7; Sat, 5 Jan 2019 15:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=6x3Hkm JPQOU1yHA/mP5vOuvI7R8=; b=oTlz6WtUF/0StxzUF0m5/uZBs9ts/jRYBWdS/D uIoJk53fyCJ7+QdVLv5xy2MTYrpQtW+VBIUA+WkNKnrma1Mj64qDn/4LGY2eWhKw pTlU5cWsEQ+lZM4rsjudEgSAIuNS9WoCpeW5Sfjv+WkBMuISAWS6vZlyRnUNudk3 rhUUY= Original-Received: from mail.jurta.org (m91-129-109-141.cust.tele2.ee [91.129.109.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTPSA id 437E47F5B8; Sat, 5 Jan 2019 15:31:49 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a35 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 4 Jan 2019 07:49:38 +0000") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrvdeggdduudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdelrddugedunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtledrudeguddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154174 Archived-At: >> xref-quit-and-goto-xref has no good keybinding. If you type TAB >> in a web browser, do you expect it to close the current window >> and open a link in a new window? > > I suggested TAB because in Emacs, tab completes stuff and closes > *completions*. So it's not consistent with web browsers but is consiste= nt > with emacs, as usual. Typing TAB in *Completions* moves point to the next completion, so in xref this corresponds to xref-next-line, and Shift-TAB moves to the previous completion that corresponds to xref-prev-line. The closest analogue to "close and do it" in Emacs I see only dired-find-alternate-file bound to =E2=80=98a=E2=80=99: diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 87ce2299c5..169f49a348 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -685,7 +674,9 @@ xref--xref-buffer-mode-map (define-key map (kbd "p") #'xref-prev-line) (define-key map (kbd "r") #'xref-query-replace-in-results) (define-key map (kbd "RET") #'xref-goto-xref) - (define-key map (kbd "TAB") #'xref-quit-and-goto-xref) + (define-key map (kbd "TAB") #'xref-next-line) + (define-key map [backtab] #'xref-prev-line) + (define-key map (kbd "a") #'xref-quit-and-goto-xref) (define-key map (kbd "C-o") #'xref-show-location-at-point) ;; suggested by Johan Claesson "to further reduce finger movement": (define-key map (kbd ".") #'xref-next-line)