From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect Date: Mon, 04 Feb 2019 22:41:54 +0000 Message-ID: <87bm3rxjkd.fsf@gmail.com> References: <87lg2x6fox.fsf@mail.linkov.net> <87h8dkk3ho.fsf@mail.linkov.net> <87y36w8qvy.fsf@gmail.com> <87o97ruu06.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28203"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34294@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 04 23:59:02 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqnCf-0007DD-VW for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 23:59:02 +0100 Original-Received: from localhost ([127.0.0.1]:50594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqnCe-0008EH-V9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 17:59:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqn9q-0005pX-Qv for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 17:56:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqmxC-0000zO-NY for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 17:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqmxC-0000zG-JS for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 17:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqmxC-0002Mi-Ci for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 17:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2019 22:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34294 X-GNU-PR-Package: emacs Original-Received: via spool by 34294-submit@debbugs.gnu.org id=B34294.15493201259023 (code B ref 34294); Mon, 04 Feb 2019 22:43:02 +0000 Original-Received: (at 34294) by debbugs.gnu.org; 4 Feb 2019 22:42:05 +0000 Original-Received: from localhost ([127.0.0.1]:59839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqmwH-0002LT-1L for submit@debbugs.gnu.org; Mon, 04 Feb 2019 17:42:05 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:39515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqmwF-0002Kz-NO for 34294@debbugs.gnu.org; Mon, 04 Feb 2019 17:42:04 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id t27so1662404wra.6 for <34294@debbugs.gnu.org>; Mon, 04 Feb 2019 14:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=CCxFoMdPnsIOWxTxoYDHG8d/++QAgFAS/DgqFvRIzoI=; b=UwgDmIm9Lk7fY8qmg8adiBkJyq+D3F4LVY0YM6IjsOzp5uzHup57zMQuXwGkf1jPsM SvQGfMPCqgsXqalsT6PxIxNcrMUwdjsRvy2o87mWu7B0rB0YJ9k4YRNddn62kGY+QQRD xe276jlXFWnthn/NbSmIIZdVYBzLW8AyQUF84GcuT+0oc/pLQXIV2Q+xrHjBbC/Onn9d CP8hQ/XCnINyzELBPcvneWW11R2iXZpR+IaOeipGGqkYLQoB8579sBW6AgJRHT51VHw5 K1xhMfD2NnBn1g/4n/oFLvDr0gzWn58RXRESNqhrSEKrTXmK9RZ3fAdRo81CJfnSLOd8 9z7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CCxFoMdPnsIOWxTxoYDHG8d/++QAgFAS/DgqFvRIzoI=; b=k3hMc2VimJ0BZXxrIvtu2eTxTt9dWIjYU2lqGOqX/4USrmUQA36TnTGfAhVPfkJx9F Qj4/z7RVpyaw4LNqO2LHSgjQrj0m/iHuUrtLsjuGp2HLloF3Q9TQZdhpqZRmNInf6p24 nei1DloJpVu6o0WOCjAy57qB8HuE8lY4s5n3Z3hGGGsuvbTwwMqIati9NRnghBJIwAFQ 9g1AaZM3TxD3YJaocBO450pptAq4WsTI5eV8AtPPc1en83OlsohCnfVOXjg9wk7TkejC DPM93H6SDMAunqTgRBtzW/56uC7CjPXHIoDaY9QMDntVRmjjg99j992bu5+S7HQpWl5y stlQ== X-Gm-Message-State: AHQUAubvfIcpeCw36rEDA7CTvijJ11g2qxFbhD4b1sF87bT/YWdfcp2t atDJXL4dmCu86sVeXWT7od3k8k39 X-Google-Smtp-Source: AHgI3IZE7P4asL+no2uWLhtYrj5ua4B4FJgHiX/SSxJXNNzjUHtXCa/5IPQpvc/TkBJaBd8SKiLjXg== X-Received: by 2002:adf:c612:: with SMTP id n18mr1184184wrg.174.1549320117422; Mon, 04 Feb 2019 14:41:57 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id s132sm9661134wmf.28.2019.02.04.14.41.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 14:41:56 -0800 (PST) In-Reply-To: <87o97ruu06.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 04 Feb 2019 23:24:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155095 Archived-At: Juri Linkov writes: >>> 4. Also I found these related entries in the same etc/TODO file: >>> >>> ** Display something in the margin on lines that have compilation >>> errors. >> >> Flymake does this, even though it uses the fringe by default, but I >> don't have more clues to what the author of this line intended. > > I guess this is exactly what Flymake already does. Then maybe remove it in a fourth patch? >>> What do you think about displaying a tooltip on the fringe indicator >>> with the same text that is displayed on the tooltip over the location >>> of the error in the source buffer? It's easier to hover on the fringe >>> than finding the location in the buffer to hover. >> >> I don't have any strong opinion. It's fine, I guess, but not >> specifically tied to Flymake. It may be difficult to implement. > > Yes, this is a more general feature. I could look at how easy it > would be to implement, and later to use in Flymake. Fine by me. I would personally concentrate efforts elsewhere, but you get to work whereever you prefer. >> BTW you can use flymake-goto-next-error and flymake-goto-prev-error to >> navigate between errors, it's what I use all the time. > > Thanks for the suggestion. I could also look how easy to integrate > flymake-goto-next-error into the more general next-error framework that > provides easy to type keybindings. This would be quite welcome, especially since I think there are revent improvements to the next-error framework. Whatever you do to flymake.el, and I forgot to mention this earlier, you have to make sure it still loads and works in Emacs 26.1, because flymake.el is also distributed through ELPA. Fifth patch. >> So to summarize, it'd be great if you could provide the three patches to >> implement the suggestions you gave. > > OK, I'll provide these three patches. But first please look at my feedba= ck > on your suggestion to set flymake-no-changes-timeout to nil: after trying= it, > I see that it helps me, but also it requires setting > flymake-start-syntax-check-on-newline to nil, because otherwise > syntax check is started on an unsaved buffer when yanking text > that contains newlines. I think flymake-start-syntax-check-on-newline should just be deprecated, set to nil, and hidden away from the user. It doesn't make much sense: I don't see why a newline is different from any other character. So you can do this in a sixth patch. Jo=C3=A3o