From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Date: Sun, 24 Mar 2019 08:06:36 -0700 Message-ID: <87bm20mhvn.fsf@ericabrahamsen.net> References: <871s2wpedf.fsf@tcd.ie> <8736nc2u8k.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="137665"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 34974@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 16:07:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h84iR-000ZfU-L7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 16:07:15 +0100 Original-Received: from localhost ([127.0.0.1]:57295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84iQ-0000qx-H0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 11:07:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84iG-0000np-5H for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h84iE-00070L-Qu for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h84iE-00070C-Ml for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h84iE-0005ds-F2; Sun, 24 Mar 2019 11:07:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <871s2wpedf.fsf@tcd.ie> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 24 Mar 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34974 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155344001721676 (code B ref -1); Sun, 24 Mar 2019 15:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Mar 2019 15:06:57 +0000 Original-Received: from localhost ([127.0.0.1]:56928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84i8-0005dX-HQ for submit@debbugs.gnu.org; Sun, 24 Mar 2019 11:06:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84i7-0005dK-5M for submit@debbugs.gnu.org; Sun, 24 Mar 2019 11:06:55 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h84i1-0006sl-UU for submit@debbugs.gnu.org; Sun, 24 Mar 2019 11:06:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84i0-0000i3-0h for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:06:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h84hy-0006r0-Dz for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:06:47 -0400 Original-Received: from [195.159.176.226] (port=46802 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h84hy-0006qN-4P for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:06:46 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h84hu-000YzL-Pa for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 16:06:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:my5wjjAR9pRyRIWzsrcFeyWMsXE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156702 Archived-At: "Basil L. Contovounesios" writes: > "Basil L. Contovounesios" writes: > >> With gnus-suppress-duplicates left at its default value of nil, trying >> to move an article with 'B m ' gives me the following backtrace: >> >> Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) >> remhash("" nil) >> gnus-dup-unsuppress-article(1988) >> gnus-summary-move-article(nil) >> funcall-interactively(gnus-summary-move-article nil) >> call-interactively(gnus-summary-move-article nil nil) >> command-execute(gnus-summary-move-article) >> >> I'm no expert, and I haven't tried reproducing this with a minimal >> config, but I think gnus-summary-move-article should not call >> gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right? >> >> This issue seems to have been uncovered by the switch to hash-tables in >> bug#33653. Previously, gnus-dup-unsuppress-article called unintern, >> which would not complain when its second argument gnus-dup-hashtb was >> nil, even though it probably should have. >> >> Patch to follow. > > Sorry, this is a duplicate of bug#34973, which was reported first and > where I've now sent my suggested patch. > > I was going to merge the two bug reports, but then I read that the > debbugs 'merge' command requires reports to be assigned to the same > package. Bah, and I'd sent in the "merge" command moments before. Trying too hard to be helpful. > This report was created by the gnus-bug command, which assigned it to > both packages emacs and gnus and version 5.13, whereas the other report > was presumably created by report-emacs-bug and assigned to the emacs > package, version 27.0.50. > > So, which package+version combination should Gnus bugs be assigned to? > How should these two reports be merged? Does merging keep all parties > CCed, or do they have to be CCed anew? > > Thanks,