From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test Date: Thu, 11 Apr 2019 10:05:00 +0200 Message-ID: <87bm1dezmb.fsf@gmx.de> References: <20190410143954.15970.66756@vcs0.savannah.gnu.org> <20190410143955.65B6320619@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170112"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 11 10:07:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEUkK-000i4w-VA for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 10:07:45 +0200 Original-Received: from localhost ([127.0.0.1]:43656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEUkJ-0004JC-NR for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 04:07:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEUhr-0002nI-Ag for emacs-devel@gnu.org; Thu, 11 Apr 2019 04:05:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEUhq-00024a-AM for emacs-devel@gnu.org; Thu, 11 Apr 2019 04:05:11 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:36909) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEUhp-00021N-Sy for emacs-devel@gnu.org; Thu, 11 Apr 2019 04:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554969902; bh=30PviWHIvUAZD06RaEMXGpoJXhwTx6MMYnNd8zzlPNg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=N8G/VJVfJLn3iAPzBOhOJsS36hAx3U/FykbksDMuD5uWSSi+MEmqs7J3f6+Of9fhp EJhkplJWFQlNU/Od5kHo+O7IF77FvpiawhT6RWTKgEZ95UEqqzaoQ0FuLuUVgAVl5N v5dADqzCIAdHdKwO4eDyHI9pIXrXTHGQeOUFL28w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.249.62]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MY3Ho-1hRZba2lNo-00UvIj; Thu, 11 Apr 2019 10:05:02 +0200 In-Reply-To: <20190410143955.65B6320619@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Wed, 10 Apr 2019 10:39:54 -0400 (EDT)") X-Provags-ID: V03:K1:HTPmhtkHsESkWHGrlpmJzxmO1nQY4agjDvZVR7QmyWg4tOAPnWp skCL1vSZDixhiYpyS3eokExyud9kh8QprZLzabS72wVENX76FFb4tJ7Hqonkk78Zm1zXlvo ElvMxm9She7E8lKuNGSmkxhS3zO8iEyQtddJ5svmVYY9tbKMSMTESoytIGs/H0GCrgQIRbZ OtOhSCk6HraLVCODIDUhQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:09lkjpfyAHE=:OZH3s3JLOD+PFuCWzKPcXx Bxks5jby4Y8NQVQ21aygUoOxp0YAjh/TZW0WBqnLD8w/QRid/WofQq6kDWerI4Wr0LCbS57WB P0CfZ+zdzyXEXFlkN1yB0G7OLNOZ3r1a2PUwgPChtNXgNzEMM2BqakMKCe96YCGMLmvCIcfIQ 6wYMMWOLv6rdQOJ61l3xGwwskpduw0uBPa5zQTi4y5s5autrpmpNR1bOwtafqgFVvY7sOUtKa vsN920ke4BJdQaJ1FAmK4h+FdriE9ZuQBRlHgOwaO0Vx3rBmyZ/Gmmm0HOxVpwAaWRJeChGgK ZeaqEUTMffHPfcvoJEj9ICXoigl7faPyZvmB7hjDXur47mLI1h9H0IsYIgRLVCRavu013+BS+ IQdswgmuLYdY8jXB3fhU5FTv+Sj8lB+9TgUP7UHYFZwoddkQEakRs3gXwzQqcmc2bkrFv/1WB iT2WV3U3CQVYEOjMdtvLyRvb7Q11UQIveY95HOPs9Q0Bi9IwOwSjcaiIpt80bIH0VFx7OxHeX oqrjT4UiyLIVhtB2FA84/nvTJEiXnvlL3NBZE1OIAYXaw0jcKNQ1ErE+WuP0M7M7zuyaA/OPG zUE/YM/01yHTzv9Dp9z4qmJcmLOUPVWi4WuTYH47KbQRDV3D0OMbnyZp9EHQ4v2VdrfLpPYuU xslm3ul50K3cJ54hkxZG1DuQxs5GVPA5ZawVOPTeuHgjf4bFZZa33VDj6ie0FrWDJ6QCg7qep xRfJBFkj19sIMiYGStS4p9nN2Yfx92E80+uruqoV/BtQRzqzbD86+g4kLMeWMvgORW26VLr8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235271 Archived-At: monnier@iro.umontreal.ca (Stefan Monnier) writes: Hi Stefan, > * test/lisp/progmodes/python-tests.el: "Fix" failing test > > (python-tests--python-nav-end-of-statement--infloop): Disable. > > --- a/test/lisp/progmodes/python-tests.el > +++ b/test/lisp/progmodes/python-tests.el > @@ -5345,13 +5345,23 @@ class SomeClass: > (ert-deftest python-tests--python-nav-end-of-statement--infloop () > "Checks that `python-nav-end-of-statement' doesn't infloop in a > buffer with overlapping strings." > + ;; FIXME: The treatment of strings has changed in the mean time, and = the > + ;; test below now neither signals an error nor inf-loops. > + ;; The description of the problem it's trying to catch is not clear e= nough > + ;; to be able to see if the underlying problem is really fixed, sadly= . > + ;; E.g. I don't know what is meant by "overlap", really. > + (skip-unless nil) The way to do this is :tags '(:unstable) This prevents the test to run via any make target, but the author is still able to run the test with a proper selector, working on this. See also .../test/README Best regards, Michael.