From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test
Date: Thu, 11 Apr 2019 10:05:00 +0200 [thread overview]
Message-ID: <87bm1dezmb.fsf@gmx.de> (raw)
In-Reply-To: <20190410143955.65B6320619@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Wed, 10 Apr 2019 10:39:54 -0400 (EDT)")
monnier@iro.umontreal.ca (Stefan Monnier) writes:
Hi Stefan,
> * test/lisp/progmodes/python-tests.el: "Fix" failing test
>
> (python-tests--python-nav-end-of-statement--infloop): Disable.
>
> --- a/test/lisp/progmodes/python-tests.el
> +++ b/test/lisp/progmodes/python-tests.el
> @@ -5345,13 +5345,23 @@ class SomeClass:
> (ert-deftest python-tests--python-nav-end-of-statement--infloop ()
> "Checks that `python-nav-end-of-statement' doesn't infloop in a
> buffer with overlapping strings."
> + ;; FIXME: The treatment of strings has changed in the mean time, and the
> + ;; test below now neither signals an error nor inf-loops.
> + ;; The description of the problem it's trying to catch is not clear enough
> + ;; to be able to see if the underlying problem is really fixed, sadly.
> + ;; E.g. I don't know what is meant by "overlap", really.
> + (skip-unless nil)
The way to do this is
:tags '(:unstable)
This prevents the test to run via any make target, but the author is
still able to run the test with a proper selector, working on this.
See also .../test/README
Best regards, Michael.
next parent reply other threads:[~2019-04-11 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190410143954.15970.66756@vcs0.savannah.gnu.org>
[not found] ` <20190410143955.65B6320619@vcs0.savannah.gnu.org>
2019-04-11 8:05 ` Michael Albinus [this message]
2019-04-11 14:33 ` master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test Stefan Monnier
2019-04-11 14:49 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm1dezmb.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.