From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add a new user option 'ido-big-directories'. Date: Wed, 17 Apr 2019 20:58:47 +0200 Message-ID: <87bm14sbko.fsf@telefonica.net> References: <20190412122301.98921-1-phst@google.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227950"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Philipp Stephani , emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 17 20:59:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGplu-000xBc-0c for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 20:59:02 +0200 Original-Received: from localhost ([127.0.0.1]:58046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGplt-0006DW-3Q for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 14:59:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGpll-0006DQ-8o for emacs-devel@gnu.org; Wed, 17 Apr 2019 14:58:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGplk-0006wU-Du for emacs-devel@gnu.org; Wed, 17 Apr 2019 14:58:53 -0400 Original-Received: from relayout01.e.movistar.es ([86.109.101.201]:19213 helo=relayout01-redir.e.movistar.es) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGplk-0006qm-3u for emacs-devel@gnu.org; Wed, 17 Apr 2019 14:58:52 -0400 Original-Received: from sky (108.red-79-151-7.dynamicip.rima-tde.net [79.151.7.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout01.e.movistar.es (Postfix) with ESMTPSA id 44ks2w2qNbzfb9g; Wed, 17 Apr 2019 20:58:48 +0200 (CEST) In-Reply-To: <20190412122301.98921-1-phst@google.com> (Philipp Stephani's message of "Fri, 12 Apr 2019 14:23:01 +0200") X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-TnetOut-Country: IP: 79.151.7.108 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout01 X-TnetOut-MsgID: 44ks2w2qNbzfb9g.ABD2A X-TnetOut-SpamCheck: no es spam, Unknown X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1556132329.09665@+KjWD4BPnxA2c4Iz0S9UsQ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.109.101.201 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235605 Archived-At: Philipp Stephani writes: > This provides an alternative to 'ido-max-directory-size', for > directories that are statically known to be too big for Ido > completion. > > * lisp/ido.el (ido-big-directories): New user option. > (ido-directory-too-big-p): Use it. What this option does is to revert to non-ido completion when the regexp matches the directory name, it has nothing to do with the directory being big. I suggest that you rename the user option accordingly and move its use outside of ido-directory-too-big-p.