From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el Date: Thu, 09 May 2019 14:39:46 +0100 Message-ID: <87bm0boifx.fsf@tcd.ie> References: <87woj1anpx.fsf@tcd.ie> <87woj117h2.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="55636"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 15:40:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOjHx-000EME-5t for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 15:40:45 +0200 Original-Received: from localhost ([127.0.0.1]:54764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOjHw-0004dK-7J for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 09:40:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOjHA-0004Xx-AP for emacs-devel@gnu.org; Thu, 09 May 2019 09:39:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOjH8-0002qw-00 for emacs-devel@gnu.org; Thu, 09 May 2019 09:39:56 -0400 Original-Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:46241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOjH5-0002lx-Bv for emacs-devel@gnu.org; Thu, 09 May 2019 09:39:53 -0400 Original-Received: by mail-ed1-x544.google.com with SMTP id f37so2033354edb.13 for ; Thu, 09 May 2019 06:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=c1pGtV+gayzhb2BISmBpDXanWR5s3adxOwZFnOpu25k=; b=aXQiHAehpYC3rthnmRqeuav3WSNU6hduu9Gm3gSVB5unBZdu99/hn1HVqlhjTRNHJ9 VtpoQ2x3+Bs/0o3PcwikMEb4/uh337bIX8cLXq6dZLYUtovZbKHGN/k9gp6L3cPY2eM2 KIepHOH1ERQXNVWlDFuJwvKMfsJIOjYwDnQV1CWgB+rUWFo83pvJ45hL0BF7JnBH7rnu A3If6DyxYM8isqPDGUuVd9ULevf2fI8WQgdU0fGvOknEcP+79b9yoVSzNq7DHqaseC85 ecm/i8qpGlkrTaB7cA05pgBTROY0TDEdvEb3jy8ScnHaVD1puNc9hljSt2FB7H6TNFtY pgrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c1pGtV+gayzhb2BISmBpDXanWR5s3adxOwZFnOpu25k=; b=RchTnvxo4CfdpUhZ7g+WCx06WosZVa3/x83MO1VQjlFUl/0UkukAlkBl4HvEnEd7CY ExcmWVumySQkteS7rWNFpnAWIepcDPluYDIKlVQb0kIeo+3cJ+L6GdRooKdySclsH2Ls Wakb+et3Xd/uNu/6/9ODkyCx7IrH/U/uZdU2UZHkOXOQ3gMfijPqtYJw018cihATyCVR ndmsQP360jFTPFiUAtpKpNfVhzIEW+IrHx+HCadnfiKd8xYSF68kyQsVE2ZhKcEbUM2I jWPR0YddQCW8xTLCjOHLY3GH35wXulzBYM5XUG8jNIl1g/XCZvwqbCr5A4MjHemqhvpO YTLg== X-Gm-Message-State: APjAAAUk6n1aEvNdaN+db5hLptjj3i3F6hwQjHCtmUWIZJh0wx+mD1d3 /OAUKi/dyISwm61oriaIpAm3tEM/qJI= X-Google-Smtp-Source: APXvYqzCwYq/X5x4NUKBsyY3lYnpNmXXXacOCv05X+oSNaFGD9ESUeeK6K9gFFbpp84Y4qsuuvKqaw== X-Received: by 2002:a50:f599:: with SMTP id u25mr4117732edm.102.1557409189375; Thu, 09 May 2019 06:39:49 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id i5sm327891ejb.24.2019.05.09.06.39.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 09 May 2019 06:39:48 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Wed, 8 May 2019 22:24:33 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236334 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas writes: > I just got back the confirmation for the copyright assignment. Great. Can someone please check that it's indeed on file? I don't think I have access to that information. > If there are no more outstanding issues, I think this is ready to be > merged. Once the assignment is confirmed on our side as well, and if no-one objects within the next few days, I or someone else will push the patch to master. > I've attached the patch (again) with a better commit message and > proper thanks given to Basil. Thanks, I noticed an additional possible cleanup: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=delim-col-headers.diff diff --git a/lisp/delim-col.el b/lisp/delim-col.el index a968b32052..910178020d 100644 --- a/lisp/delim-col.el +++ b/lisp/delim-col.el @@ -5,8 +5,8 @@ ;; Author: Vinicius Jose Latorre ;; Maintainer: Vinicius Jose Latorre ;; Version: 2.1 -;; Keywords: internal -;; X-URL: http://www.emacswiki.org/cgi-bin/wiki/ViniciusJoseLatorre +;; Keywords: convenience text +;; X-URL: https://www.emacswiki.org/emacs/ViniciusJoseLatorre ;; This file is part of GNU Emacs. @@ -125,6 +125,7 @@ columns "Prettify columns." :link '(emacs-library-link :tag "Source Lisp File" "delim-col.el") :prefix "delimit-columns-" + :group 'convenience :group 'text) (defcustom delimit-columns-str-before "" --=-=-= Content-Type: text/plain Any objections? Thanks, -- Basil --=-=-=--