From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 35476@debbugs.gnu.org
Subject: bug#35476: font-lock-{append, prepend}-text-property and anonymous faces
Date: Tue, 14 May 2019 08:01:04 +0200 [thread overview]
Message-ID: <87bm05inhb.fsf@gmail.com> (raw)
In-Reply-To: <87v9ydg87m.fsf@gmail.com> (Noam Postavsky's message of "Mon, 13 May 2019 21:01:33 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> [1] Although running 'make lisp/font-lock-tests' in the test/ folder
>> fails on the append test. Could it be that the Makefile runs the
>> tests against the old font-lock.el that is installed on my system,
>> rather than the new one in my repository? I took a look at the
>> test_template in test/Makefile, but I could not understand what the
>> machinery loads at a glance.
>
> I forgot to answer this before. There's two issues here:
>
> 1. The default value of load-prefer-newer means that of you change a .el
> file without recompiling it, Emacs will load the .elc file instead.
>
> 2. For font-lock.el in particular, it's preloaded, so even if you
> recompile it, font-lock.elc isn't loaded again, you need to redump
> Emacs.
Duly noted, I'll watch out for that in the future.
> So generally, the way to test changes is
>
> make && make -C test font-lock-tests
>
> Although it should also work to load the modified .el file explicitly
> (untested, but):
>
> make -C test EMACS_EXTRAOPT='-l font-lock.el' font-lock-tests
Just tried with and without EMACS_EXTRAOPT, and it does seem to work
around the problem.
>> Can e.g. git-show(1) understand action stamps? I glanced at
>> gitrevisions(7) but nothing suggests Git knows anything about this
>> format.
>
> I don't think so. The last time I brought this up on emacs-devel there
> was some suggestion that cgit (a git web frontend) would learn to
> recognize them eventually, but I'm not sure if anything is really moving
> in that direction.
>
>> (Or, going the opposite route, maybe the git-log-to-ChangeLog machinery
>> could translate hashes to action stamps?)
>
> Maybe, although personally, as a human reader, I prefer date+title to
> both hashes and action stamps, even when reading from git. Yes, it's
> quicker to find a commit given a hash, but that still requires at least
> pressing RET or clicking or something like that. Quite often, just
> seeing the title is enough to understand what's meant and I don't need
> to dig further.
OK. FWIW, since I like to give context to my messages and I expect to
be doing the hash ↦ date+title dance a lot, this command seems to do the
job adequately for commit $c:
git show --no-patch --date=short --format=format:'%ad "%s"' $c
Now to write some Lisp to make that available from vc and magit buffers…
(one-liner for action stamps left as exercise to the reader)
> I think we're good here, pushed to master.
Thanks!
prev parent reply other threads:[~2019-05-14 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 17:11 bug#35476: [PATCH] 27.0.50; font-lock-{append,prepend}-text-property and anonymous faces Kévin Le Gouguec
2019-04-30 6:08 ` bug#35476: Test suite Kévin Le Gouguec
2019-05-07 5:24 ` bug#35476: [BUMP] Some questions before closing Kévin Le Gouguec
2019-05-12 12:28 ` bug#35476: font-lock-{append, prepend}-text-property and anonymous faces Noam Postavsky
2019-05-12 17:34 ` Kévin Le Gouguec
2019-05-12 19:09 ` Noam Postavsky
2019-05-12 21:51 ` Kévin Le Gouguec
2019-05-14 1:01 ` Noam Postavsky
2019-05-14 6:01 ` Kévin Le Gouguec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm05inhb.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=35476@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.