From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: master fbd2ea1 2/2: Fix two parse-time-months invalid assumptions
Date: Fri, 02 Aug 2019 20:19:02 +0200 [thread overview]
Message-ID: <87blx7mnvt.fsf@gmx.de> (raw)
In-Reply-To: <20190801224721.CC60820CC8@vcs0.savannah.gnu.org> (Paul Eggert's message of "Thu, 1 Aug 2019 18:47:21 -0400 (EDT)")
eggert@cs.ucla.edu (Paul Eggert) writes:
Hi Paul,
> --- a/lisp/net/tramp-smb.el
> +++ b/lisp/net/tramp-smb.el
> @@ -1814,6 +1814,9 @@ Result is the list (LOCALNAME MODE SIZE MTIME)."
> (if (and sec min hour day month year)
> (encode-time
> sec min hour day
> + ;; FIXME: Won't this fail if parse-time-months is configured
> + ;; by the user? See "The date/time prompt" in the Org manual.
> + ;; If the code is OK as-is, perhaps explain why in a comment.
> (cdr (assoc (downcase month) parse-time-months))
> year)
> tramp-time-dont-know))
Thanks for the hint. I understand `parse-time-months' that one could
*add* own entries, w/o removing existing ones. That's why nobody has
reported an error here for the last 15+ years.
But you are right, it is not guaranteed. So I have adapted the code in
order to ensure proper `parse-time-months' value.
Best regards, Michael.
next parent reply other threads:[~2019-08-02 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190801224719.32485.19688@vcs0.savannah.gnu.org>
[not found] ` <20190801224721.CC60820CC8@vcs0.savannah.gnu.org>
2019-08-02 18:19 ` Michael Albinus [this message]
2019-08-02 18:38 ` master fbd2ea1 2/2: Fix two parse-time-months invalid assumptions Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blx7mnvt.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.