From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11929: 24.1.50; Globalized minor mode turn-on function is called twice for each opened file Date: Sat, 17 Aug 2019 14:59:14 -0700 Message-ID: <87blwnlah9.fsf@mouse.gnus.org> References: <4FFFA314.5030509@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="131898"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 11929@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 00:00:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hz6kF-000Y7Y-60 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 00:00:19 +0200 Original-Received: from localhost ([::1]:38256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hz6kD-00038w-W2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Aug 2019 18:00:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43484) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hz6k0-00038h-F6 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 18:00:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hz6jz-0004wZ-C9 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 18:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hz6jz-0004vg-8G for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 18:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hz6jz-00054O-27 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 18:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2019 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11929 X-GNU-PR-Package: emacs Original-Received: via spool by 11929-submit@debbugs.gnu.org id=B11929.156607916519415 (code B ref 11929); Sat, 17 Aug 2019 22:00:02 +0000 Original-Received: (at 11929) by debbugs.gnu.org; 17 Aug 2019 21:59:25 +0000 Original-Received: from localhost ([127.0.0.1]:56977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz6jM-000535-VS for submit@debbugs.gnu.org; Sat, 17 Aug 2019 17:59:25 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz6jJ-00052t-OD for 11929@debbugs.gnu.org; Sat, 17 Aug 2019 17:59:23 -0400 Original-Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hz6jF-0004LF-TC; Sat, 17 Aug 2019 23:59:20 +0200 In-Reply-To: <4FFFA314.5030509@yandex.ru> (Dmitry Gutov's message of "Fri, 13 Jul 2012 08:24:52 +0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165289 Archived-At: Dmitry Gutov writes: > 1. Define the minor mode: > > (define-minor-mode foo-mode "" :lighter "") > > (defun turn-on-foo-mode () > (message "buffer %s major mode %s" (buffer-name) major-mode) > (foo-mode 1)) > > (define-globalized-minor-mode global-foo-mode foo-mode turn-on-foo-mode) > > 2. Turn on the global mode. > > 3. Open any file, look at the *Messages* buffer. > It will contain something like this: > > buffer init.el major mode fundamental-mode > buffer init.el major mode emacs-lisp-mode > > If the buffer is going to be immediately switched to another mode, > there's no point in calling the turn-on function in the default mode. > I think this behavior is buggy. If I understand you correctly, you don't think that buffers should first be opened in `fundamental-mode', and then the "real" major mode, because this means that globalised minor modes get switched on twice? I agree that this seems like surprising behaviour, but I think it's been this way since forever, so perhaps it should just be documented? I'm not sure where, though... in the `define-globalized-minor-mode' doc string, perhaps? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no