From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36780: 26.1; request: savehist should also save log-edit-comment-ring by default Date: Fri, 23 Aug 2019 07:12:57 +0200 Message-ID: <87blwgforq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="139623"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36780@debbugs.gnu.org To: ndame Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 07:42:56 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i12Le-000a9z-Rm for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 07:42:54 +0200 Original-Received: from localhost ([::1]:51716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i12Ld-0003yj-BS for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 01:42:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45533) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i11tj-0007AB-TP for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 01:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i11ti-00047p-Nn for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 01:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58281) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i11ti-00047e-KV for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 01:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i11ti-00011B-EM for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 01:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 05:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36780 X-GNU-PR-Package: emacs Original-Received: via spool by 36780-submit@debbugs.gnu.org id=B36780.15665371833825 (code B ref 36780); Fri, 23 Aug 2019 05:14:02 +0000 Original-Received: (at 36780) by debbugs.gnu.org; 23 Aug 2019 05:13:03 +0000 Original-Received: from localhost ([127.0.0.1]:38869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11sl-0000zd-Dp for submit@debbugs.gnu.org; Fri, 23 Aug 2019 01:13:03 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:40628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11sj-0000zD-Ba for 36780@debbugs.gnu.org; Fri, 23 Aug 2019 01:13:01 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i11sf-000448-J8; Fri, 23 Aug 2019 07:13:00 +0200 In-Reply-To: (ndame's message of "Wed, 24 Jul 2019 10:59:05 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165642 Archived-At: ndame writes: > When committing things with vc I often reuse previous commit messages, > usually by editing them a bit. So it's very annoying when I restart > emacs and lose the commit message history. > > I now added log-edit-comment-ring to savehist-additional-variables, > but it should be the default, because minibuffer histories are saved > by default, so I'd expect vc commit messages are also saved, though it > does not use the minibuffer, but it is frequently used input field. > > I recommend adding > > (add-to-list 'savehist-additional-variables 'log-edit-comment-ring) > > to log-edit.el, so if savehist is enabled then it is saved as well. `savehist-additional-variables' is explicitly reserved for users to add stuff to, so I don't think it'd be appropriate for log-edit.el to add anything to it. But we could add a new variable, say `savehist-variables', that as a default value could be (log-edit-comment-ring) and anything else the Emacs maintainers think could be saved by default. Opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no