From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36830@debbugs.gnu.org, gusbrs.2016@gmail.com
Subject: bug#36830: 26.2; find-file-visit-truename is not honored as file local variable
Date: Sun, 25 Aug 2019 07:39:29 +0200 [thread overview]
Message-ID: <87blwdajn2.fsf@gnus.org> (raw)
In-Reply-To: <83d0gvk5m0.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Aug 2019 23:07:51 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I don't think this variable was designed to be set from file-local
> variables block. Visiting a file and naming its buffer are two racy
> actions, and where there's a race there will be chicken-and-egg type
> of problems.
[...]
> I expect such renaming to cause future bugs, FWIW. Or maybe not, but
> this is beyond hacky, IMO.
Yes, I think so, too, but:
> Maybe we should just document that this variable cannot be file-local.
files.el has this:
(put 'find-file-visit-truename 'safe-local-variable 'booleanp)
It was changed to booleanp in 2007 (from the presumably invalid
`boolean'), so it didn't work before 2007 for that reason, and it hasn't
worked after 2007 because it's checked too late.
So perhaps the fix here is to just remove that `put'?
On the other hand, it would be nice if it worked, because it seems like
a pretty useful thing to be able to customise on a per-file basis.
Perhaps.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-25 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 15:21 bug#36830: 26.2; find-file-visit-truename is not honored as file local variable Gustavo Barros
2019-08-23 5:05 ` Lars Ingebrigtsen
2019-08-23 13:04 ` Gustavo Barros
2019-08-23 18:59 ` Lars Ingebrigtsen
2019-08-23 20:07 ` Eli Zaretskii
2019-08-23 21:38 ` Gustavo Barros
2019-08-25 5:39 ` Lars Ingebrigtsen [this message]
2019-08-25 7:31 ` Eli Zaretskii
2019-10-14 21:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blwdajn2.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=36830@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gusbrs.2016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.