From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Tue, 15 Oct 2019 22:44:41 +0300 Organization: LINKOV.NET Message-ID: <87bluhokt2.fsf@mail.linkov.net> References: <990000647.207452.1567431109138@mail1.libero.it> <871rwy8osi.fsf@mail.linkov.net> <1202539102.243582.1567500548055@mail1.libero.it> <87h85t41cl.fsf@mail.linkov.net> <1215808011.309641.1567585329369@mail1.libero.it> <87k1answzi.fsf@mail.linkov.net> <1448946011.413994.1567719646039@mail1.libero.it> <8736h6v8v8.fsf@mail.linkov.net> <1255500419.255917.1568620575342@mail1.libero.it> <815541529.259638.1568623550774@mail1.libero.it> <87d0g00y61.fsf@mail.linkov.net> <1974399400.832770.1570978188863@mail1.libero.it> <83eezglm4r.fsf@gnu.org> <87zhi48fig.fsf@mail.linkov.net> <83tv8bkf3g.fsf@gnu.org> <83pniyh27y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31262"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 15 21:47:46 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKSnI-0007vH-J4 for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 21:47:44 +0200 Original-Received: from localhost ([::1]:57770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKSnH-0000ZN-EQ for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 15:47:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKSnA-0000Z1-5y for emacs-devel@gnu.org; Tue, 15 Oct 2019 15:47:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKSn8-0001YY-ND for emacs-devel@gnu.org; Tue, 15 Oct 2019 15:47:35 -0400 Original-Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:4134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKSn4-0001VV-2s; Tue, 15 Oct 2019 15:47:32 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DED2D7410C2; Tue, 15 Oct 2019 19:47:25 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com (100-96-90-126.trex.outbound.svc.cluster.local [100.96.90.126]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3AEA27416E3; Tue, 15 Oct 2019 19:47:25 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 15 Oct 2019 19:47:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Keen-Arch: 6762baf45520358b_1571168845440_2959225502 X-MC-Loop-Signature: 1571168845440:2674463731 X-MC-Ingress-Time: 1571168845439 Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id D5F7280822; Tue, 15 Oct 2019 12:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=3LHo1K QgwescFIWCm+i1wbUnZVw=; b=iD+kmai88NGJBlinufQO/5vkW1nt/YeDpND9J5 T4fhqmlJuHWm6HahGVdEiCRGAf5vsX9SIwRd71+egzc9ikjOMzuMbQQ7a5m/1GHr V/JPRY5Xyf/504ue89O321R93aJnVFChpH6H36amssks/bltax5LtpwfYrEsj/UW Samcw= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 1FDFC807BC; Tue, 15 Oct 2019 12:47:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a54 In-Reply-To: <83pniyh27y.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Oct 2019 10:55:45 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241062 Archived-At: >> > The problem is that tab-bar.el is pre-loaded by loadup.el and >> > dumped with the value of data-directory from the source location. >> > So running from the dump file even in the install directory >> > still uses source data-directory. >>=20 >> Why can't you compute the value at run time, rather than at dump time? >> Like the first time the tab bar is activated? > > I see that you have done so, thanks. > > However, there should be no need to explicitly expand-file-name for > the image files, as the documentation of the :file attribute says: > > =E2=80=98:file FILE=E2=80=99 > This says to load the image from file FILE. If FILE is not an > absolute file name, it is expanded relative to the =E2=80=98imag= es=E2=80=99 > subdirectory of =E2=80=98data-directory=E2=80=99, and failing th= at, relative to the > directories listed by =E2=80=98x-bitmap-file-path=E2=80=99 (*not= e Face > Attributes::). > > So by explicitly calling expand-file-name, you introduce a subtle > misfeature, whereby x-bitmap-file-path will not be consulted. I thought first to check with file-exists-p, but it seems with relative file names this is unnecessary, so I removed this. Or maybe even better would be to use find-image? What still worries me is that when the image file doesn't exist then large rectangles are displayed instead. I'd like to not put display property when the image file doesn't exist.