From: "Michał Krzywkowski" <mkrzywkow@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37892@debbugs.gnu.org, "Michał Krzywkowski" <mkrzywkow@gmail.com>
Subject: bug#37892: 27.0.50; Crash when signaling a thread
Date: Sat, 26 Oct 2019 14:29:43 +0200 [thread overview]
Message-ID: <87blu3lmfc.fsf@gmail.com> (raw)
In-Reply-To: <83sgnhw6xr.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> From: Michał Krzywkowski <mkrzywkow@gmail.com>
>> Date: Wed, 23 Oct 2019 19:06:42 +0200
>>
>> When I evaluate this sexp, Emacs aborts:
>>
>> (let ((thread (make-thread (lambda () (sit-for 1.0)))))
>> (sit-for 0.5)
>> (thread-signal thread 'error nil))
>>
>> Backtrace:
>>
>> Thread 5 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=sig@entry=6, backtrace_limit=backtrace_limit@entry=40) at emacs.c:371
>> 371 signal (sig, SIG_DFL);
>> #0 0x000000000041f40b in terminate_due_to_signal (sig=sig@entry=6, backtrace_limit=backtrace_limit@entry=40) at emacs.c:371
>> #1 0x000000000041f866 in emacs_abort () at sysdep.c:2450
>> #2 0x000000000042154b in signal_or_quit (error_symbol=XIL(0x90), data=XIL(0), keyboard_quit=<optimized out>) at eval.c:1598
>> #3 0x0000000000421564 in Fsignal (error_symbol=<optimized out>, data=<optimized out>) at eval.c:1568
>> #4 0x0000000000423929 in post_acquire_global_lock (self=<optimized out>) at thread.c:115
>> #5 0x00000000005c5e62 in acquire_global_lock (self=0x1465e50) at thread.c:123
Eli> Emacs doesn't allow signals while it waits for input.
Eli> We could ignore thread-signal in such cases, or we could make it an
Eli> error (which will then signal an error in the thread which called
Eli> thread-signal). What do people think? Are there any other ideas for
Eli> handling this situation?
Maybe the signal should be raised in the thread right after it returns
from sit-for? Ignoring signals sounds like a bad idea.
Eli> Michał, can you tell why you needed to call thread-signal while the
Eli> thread was in sit-for?
I wanted to signal some background thread which was doing some work and
then Emacs crashed, because it just so happened that it was in sit-for.
The thread function was doing _more_ than just sit-for.
I actually don't care (and can't know) what another thread is doing, I
just want to send a signal to it.
Eli> Thanks.
Thank you.
--
Michał Krzywkowski
PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-10-26 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 17:06 bug#37892: 27.0.50; Crash when signaling a thread Michał Krzywkowski
2019-10-25 8:44 ` Eli Zaretskii
2019-10-26 12:29 ` Michał Krzywkowski [this message]
2019-10-26 12:58 ` Eli Zaretskii
2019-10-27 10:16 ` Michał Krzywkowski
2019-10-27 13:25 ` Eli Zaretskii
2019-10-27 19:26 ` Michał Krzywkowski
2021-12-05 3:15 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blu3lmfc.fsf@gmail.com \
--to=mkrzywkow@gmail.com \
--cc=37892@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.