From: Lars Ingebrigtsen <larsi@gnus.org>
To: handa.kenichi@aist.go.jp (K.Handa)
Cc: xsrvmy@gmail.com, 35079@debbugs.gnu.org
Subject: bug#35079: 26.1; Font rendering - problem with bdf fonts
Date: Sun, 17 Nov 2019 10:01:16 +0100 [thread overview]
Message-ID: <87bltaanc3.fsf@gnus.org> (raw)
In-Reply-To: <87h8b2chv8.fsf@aist.go.jp> (K. Handa's message of "Sat, 13 Apr 2019 19:35:55 +0900")
handa.kenichi@aist.go.jp (K.Handa) writes:
> Or, please try to apply this patch to src/xftfont.c, and rebuild emacs.
>
> diff --git a/src/xftfont.c b/src/xftfont.c
> index 8a4516f7f9..bb15a83685 100644
> --- a/src/xftfont.c
> +++ b/src/xftfont.c
> @@ -349,7 +349,7 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
>
> if (spacing != FC_PROPORTIONAL
> #ifdef FC_DUAL
> - && spacing != FC_DUAL
> + && spacing != FC_DUAL && spacing != FC_CHARCELL
> #endif /* FC_DUAL */
> )
> {
>
> I don't know the exact meaning of FC_CHARCELL. I could't find it on the
> Internet. Does anyone know what it means and why fontconfig uses it for
> the gnu unifont?
It seems like many people are wondering what it means, but
https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/176#note_221223
says
"FC_DUAL should be an alias to FC_CHARCELL and use FC_CHARCELL in this
case too perhaps"
So it seems like the solution here is possibly correct (although perhaps
there should be an #ifdef FC_CHARCELL there, too).
It seems like it shouldn't hurt, at least.
Opinions? If nobody objects, then perhaps the following could be
installed:
diff --git a/src/xftfont.c b/src/xftfont.c
index e003580817..fa06d96736 100644
--- a/src/xftfont.c
+++ b/src/xftfont.c
@@ -211,6 +211,9 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
#ifdef FC_DUAL
&& spacing != FC_DUAL
#endif /* FC_DUAL */
+#ifdef FC_CHARCELL
+ && spacing != FC_CHARCELL
+#endif /* FC_CHARCELL */
)
{
font->min_width = font->max_width = font->average_width
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-11-17 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 5:31 bug#35079: 26.1; Font rendering - problem with bdf fonts Max Xiong
2019-04-02 14:56 ` Eli Zaretskii
2019-04-13 10:35 ` K.Handa
2019-05-03 8:36 ` Eli Zaretskii
2019-05-06 13:12 ` handa
2019-11-17 9:01 ` Lars Ingebrigtsen [this message]
2019-11-17 16:03 ` Eli Zaretskii
2019-11-17 16:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bltaanc3.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=35079@debbugs.gnu.org \
--cc=handa.kenichi@aist.go.jp \
--cc=xsrvmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.