From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Federico Tedin <federicotedin@gmail.com>
Cc: 39596@debbugs.gnu.org
Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell
Date: Wed, 19 Feb 2020 08:40:19 +0100 [thread overview]
Message-ID: <87blpvc9ek.fsf@ambrevar.xyz> (raw)
In-Reply-To: <m1k14jpjqo.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Thanks for looking at this, Federico!
Your patch looks good to me, just one comment below:
> --- a/lisp/eshell/em-dirs.el
> +++ b/lisp/eshell/em-dirs.el
> @@ -191,6 +191,9 @@ eshell-dirs-initialize
> (unless (ring-empty-p eshell-last-dir-ring)
> (expand-file-name
> (ring-ref eshell-last-dir-ring 0))))
> + t)
> + ("INSIDE_EMACS" ,(lambda (_indices)
> + (format "%s,eshell" emacs-version))
> t))))
Why did you unquote the lambda here?
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-19 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:17 bug#39596: 26.3; Export INSIDE_EMACS with Eshell Pierre Neidhardt
2020-02-18 23:18 ` Federico Tedin
2020-02-19 7:40 ` Pierre Neidhardt [this message]
2020-02-19 16:22 ` Federico Tedin
2020-02-19 16:30 ` Pierre Neidhardt
2020-02-19 17:10 ` Andreas Schwab
2020-02-19 21:16 ` Federico Tedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blpvc9ek.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=39596@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.